Rejig item-filter as horizontal flex row, drop products-layout sidebar#1399
Merged
stefan-burke merged 1 commit intomainfrom May 5, 2026
Merged
Rejig item-filter as horizontal flex row, drop products-layout sidebar#1399stefan-burke merged 1 commit intomainfrom
stefan-burke merged 1 commit intomainfrom
Conversation
Drop the products-layout sidebar wrapper; the filter now sits as a single flex row above the items list. Styles are rewritten on the design-system 8px spacing/radius/transition tokens so the filter blends in regardless of which CSS bundle a layout uses. category-filter.js now finds the items list via parentElement instead of the removed products-layout container. Also delete the unused filtered-items-section.html template. https://claude.ai/code/session_015esHZx6y73YG4ZcyPs8EDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
item-filteras a single flex-wrap row of filter groups (with a sort dropdown), built on the design-system tokens ($space-*,$radius-*,$transition-*,$border-light). Active filter pills render above the row when present..products-layout/.products-contentsidebar wrapper now that the filter sits inline above the items list.products-layout-start.html,products-layout-end.html, and the unusedfiltered-items-section.htmlare deleted;products-filter.scssis replaced byitem-filter.scss, wired into both the legacybundle.scssanddesign-system-bundle.scss.category-filter.jsnow locates the items list viacontainer.parentElement?.querySelector(".items")since the old.products-layoutancestor is gone.Test plan
bun test— 2965 pass, 0 failbun run build— both bundles compile, both contain.item-filterstylesbun run lint— clean/categories/doodahs/) and/products/: filter renders as a tidy horizontal row, chips toggle, sort dropdown works, active pills + clear-all show after a selectionhttps://claude.ai/code/session_015esHZx6y73YG4ZcyPs8EDK
Generated by Claude Code