Remove misleading "JavaScript is required" notice from sort dropdown#1400
Merged
stefan-burke merged 1 commit intomainfrom May 5, 2026
Merged
Remove misleading "JavaScript is required" notice from sort dropdown#1400stefan-burke merged 1 commit intomainfrom
stefan-burke merged 1 commit intomainfrom
Conversation
The noscript fallback already renders a working list of sort links, so the claim that JavaScript is required is incorrect — sorting works fine without JS via the link list. https://claude.ai/code/session_01L87rRST6ndvyUzJpMr8fLe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<noscript>fallback for the sort dropdown already renders a fully working list of sort links, so claiming "JavaScript is required for the sort dropdown" is inaccurate — users without JS can still sort by clicking the links.<p>notice fromsrc/_includes/filter-sort-dropdown.html; the link-list fallback remains.Test plan
/categories/doodahs), and confirm the sort link list renders without the misleading paragraph.<select>dropdown still works and the noscript content stays hidden.https://claude.ai/code/session_01L87rRST6ndvyUzJpMr8fLe
Generated by Claude Code