Style nested ULs in filter-groups as horizontal flex rows#1401
Merged
stefan-burke merged 1 commit intomainfrom May 5, 2026
Merged
Style nested ULs in filter-groups as horizontal flex rows#1401stefan-burke merged 1 commit intomainfrom
stefan-burke merged 1 commit intomainfrom
Conversation
The noscript fallback in filter-sort-dropdown.html renders a <ul> inside a <noscript> tag, so the previous `.filter-groups > li > ul` direct-child selector skipped it. Drop the `>` so any ul inside a filter-group li (including the noscript fallback) gets the horizontal flex-wrap layout. https://claude.ai/code/session_015esHZx6y73YG4ZcyPs8EDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.filter-groups > li > uldirect-child selector skipped any<ul>not directly nested under the filter-group<li>— notably the noscript fallback list insidefilter-sort-dropdown.html, which renders<noscript><p>…</p><ul>…</ul></noscript>.>so any<ul>inside a filter-group<li>gets the horizontalflex-wraplayout and pill-style option styling, regardless of nesting depth.Test plan
bun run build) and confirm the filter UI renders unchanged with JS enabled.https://claude.ai/code/session_015esHZx6y73YG4ZcyPs8EDK
Generated by Claude Code