Migrate cart-overlay and quote-cart styles into the design system#1403
Merged
stefan-burke merged 1 commit intomainfrom May 5, 2026
Merged
Migrate cart-overlay and quote-cart styles into the design system#1403stefan-burke merged 1 commit intomainfrom
stefan-burke merged 1 commit intomainfrom
Conversation
Cart-item-controls, the cart-overlay dialog, and the quote-cart blocks were all styled in the legacy src/css/cart.scss with raw values (0.75rem, 1.5rem, etc.) instead of design-system tokens. Move the cart-overlay (and its cart-item, cart-item-info, cart-item-controls, cart-checkout, etc.), the quote-cart family, and the quote-price summary into new files under src/css/design-system/, scoped to .design-system and using $space-*, $border-light, $radius-md, and button-* mixins. Wrap the cart-icon, cart-overlay, and theme-switcher includes in <div class="design-system"> from base.html so the design-system styles also win on legacy layouts. The cart.html template now wraps quantity-controls in .item-quantity for consistency with list-item-cart-controls. Legacy cart.scss is reduced to the inline list-item widgets (still needed by products listings and item-reviews that are not yet wrapped in .design-system) plus the global dialog-scroll-lock rule that has to stay outside the scope. https://claude.ai/code/session_01MyGvKCdJGipPrBLSAm13V6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.cart-item,.cart-item-info,.cart-item-controls,.cart-checkout, etc.), the quote-cart family, and the quote-price summary out of the legacysrc/css/cart.scssinto new design-system partials (src/css/design-system/_cart.scss,_quote-cart.scss).$space-*,$border-light,$radius-md) and mixins (button-primary,button-ghost,flex-col,flex-between,dialog-box) instead of the raw values that were sprinkled throughcart.scss.theme-switcher,cart-icon, andcart-overlayin a<div class="design-system">frombase.htmlso the design-system styles also win on legacy layouts (products listings, item-reviews, page)..item-quantityto matchlist-item-cart-controls, so a single widget rule covers both contexts.cart.scssis reduced to the inline list-item widgets (still needed by layouts not yet wrapped in.design-system) plus the globaldialog-scroll-lockrule that has to live outside the design-system scope.Test plan
bun run buildsucceeds and emits scoped.design-system .cart-*/.quote-*rules in bothbundle.cssanddesign-system-bundle.css.bun testpasses (3047 unit + integration tests, design-system scoping check, copy-paste detection, lint, typecheck, build)./quote/,/checkout/) and verify the quote-cart, quote-checkout summary, and stickyquote-priceaside still look right.https://claude.ai/code/session_01MyGvKCdJGipPrBLSAm13V6
Generated by Claude Code