Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Make threshold limit text clearer #3507

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

pauby
Copy link
Member

@pauby pauby commented Sep 2, 2024

Description Of Changes

Updated the threshold text to make it easier to understand.

Motivation and Context

The text that Chocolatey CLI displays can be confusing. Particularly, when the search result shows less than 1000 packages on-screen (as they have been filtered out).

Testing

N/A

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

N/A

@pauby pauby requested a review from gep13 September 2, 2024 15:04
@pauby
Copy link
Member Author

pauby commented Sep 2, 2024

@gep13 this is a change that we had discussed a little while ago related to #3502.

@pauby pauby changed the title (maint) Make threashold limit text clearer (maint) Make threshold limit text clearer Sep 2, 2024
@pauby pauby force-pushed the maint/clarify-package-threshold branch from e688f1c to ce23de6 Compare September 2, 2024 15:08
@gep13 gep13 linked an issue Oct 24, 2024 that may be closed by this pull request
6 tasks
@corbob corbob force-pushed the maint/clarify-package-threshold branch from ce23de6 to 3b32043 Compare October 31, 2024 19:32
Copy link
Member

@corbob corbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corbob corbob merged commit 7f7186f into chocolatey:develop Oct 31, 2024
5 checks passed
@corbob
Copy link
Member

corbob commented Oct 31, 2024

Thanks for getting this fixed up @pauby

corbob added a commit to corbob/choco that referenced this pull request Nov 1, 2024
The integration test for PageSize broke because the message was changed
in chocolatey#3507. This updated the test to use the new wording.
corbob added a commit to corbob/choco that referenced this pull request Nov 4, 2024
The integration test for PageSize broke because the message was changed
in chocolatey#3507. This updated the test to use the new wording.
corbob added a commit to corbob/choco that referenced this pull request Nov 4, 2024
The integration test for PageSize broke because the message was changed
in chocolatey#3507. This updated the test to use the new wording.
corbob added a commit to corbob/choco that referenced this pull request Nov 5, 2024
The integration test for PageSize broke because the message was changed
in chocolatey#3507. This updated the test to use the new wording.
@corbob corbob added the Requires Upstream Change Requires changes to a different location once issue is fixed or implemented label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Requires Upstream Change Requires changes to a different location once issue is fixed or implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With S3bucket as Sleet source choco cannot list more than 30 packages
2 participants