-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(maint) Make threshold limit text clearer #3507
Merged
corbob
merged 1 commit into
chocolatey:develop
from
pauby:maint/clarify-package-threshold
Oct 31, 2024
Merged
(maint) Make threshold limit text clearer #3507
corbob
merged 1 commit into
chocolatey:develop
from
pauby:maint/clarify-package-threshold
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauby
changed the title
(maint) Make threashold limit text clearer
(maint) Make threshold limit text clearer
Sep 2, 2024
pauby
force-pushed
the
maint/clarify-package-threshold
branch
from
September 2, 2024 15:08
e688f1c
to
ce23de6
Compare
6 tasks
corbob
force-pushed
the
maint/clarify-package-threshold
branch
from
October 31, 2024 19:32
ce23de6
to
3b32043
Compare
corbob
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for getting this fixed up @pauby |
corbob
added a commit
to corbob/choco
that referenced
this pull request
Nov 1, 2024
The integration test for PageSize broke because the message was changed in chocolatey#3507. This updated the test to use the new wording.
corbob
added a commit
to corbob/choco
that referenced
this pull request
Nov 4, 2024
The integration test for PageSize broke because the message was changed in chocolatey#3507. This updated the test to use the new wording.
corbob
added a commit
to corbob/choco
that referenced
this pull request
Nov 4, 2024
The integration test for PageSize broke because the message was changed in chocolatey#3507. This updated the test to use the new wording.
corbob
added a commit
to corbob/choco
that referenced
this pull request
Nov 5, 2024
The integration test for PageSize broke because the message was changed in chocolatey#3507. This updated the test to use the new wording.
corbob
added
the
Requires Upstream Change
Requires changes to a different location once issue is fixed or implemented
label
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Requires Upstream Change
Requires changes to a different location once issue is fixed or implemented
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Updated the threshold text to make it easier to understand.
Motivation and Context
The text that Chocolatey CLI displays can be confusing. Particularly, when the search result shows less than 1000 packages on-screen (as they have been filtered out).
Testing
N/A
Operating Systems Testing
N/A
Change Types Made
Change Checklist
Related Issue
N/A