Add checksum verification for file protocol in Get-ChocolateyWebFile #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3515 Add checksum verification for "file:" protocol in Get-ChocolateyWebFile function. * Add checksum verification for the `file:` protocol using the `Get-ChecksumValid` function. * Skip copying the file if the checksum is valid. * Copy the file if the checksum is invalid. * Continue calling `Get-ChocolateyWebFile` to download files in `Install-ChocolateyPackage` function. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/chocolatey/choco/issues/3515?shareId=XXXX-XXXX-XXXX-XXXX).
|
|
|
@nap123-sys Thanks for the PR. As I mentioned over on this comment, We have a PR template that needs to be completed, which was removed in this case, and CONTRIBUTING and COMMITTERS documentation that needs to be followed. Part of that is getting buy-in from the team on any raised issue. This didn't happen here. But the documentation will help if you submit a PR in future. Thanks again for the PR and for contributing to Chocolatey CLI. For the reasons I mentioned above, I'll close this now. |
|
Alright. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3515
Add checksum verification for "file:" protocol in Get-ChocolateyWebFile function.
file:protocol using theGet-ChecksumValidfunction.Get-ChocolateyWebFileto download files inInstall-ChocolateyPackagefunction.For more details, open the Copilot Workspace session.