Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Move support exclusion to VCR filter #3630

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This updates the settings.kts file by moving the support filter from VCS
to the VCS filter.

Motivation and Context

This is believed to be the correct place to be able to filter out the
support branch, while still being able to manually initiate a build on
the branch.

Testing

N/A

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.
  • Build

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

N/A

This updates the settings.kts file by moving the support filter from VCS
to the VCS filter.

This is believed to be the correct place to be able to filter out the
support branch, while still being able to manually initiate a build on
the branch.
@AdmiringWorm AdmiringWorm self-assigned this Feb 6, 2025
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's take this for a spin...

@gep13 gep13 merged commit 8845afd into chocolatey:develop Feb 6, 2025
4 of 5 checks passed
@AdmiringWorm AdmiringWorm deleted the fix-vcs-triggering branch February 11, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants