Fix for 10.5 #33
Open
Fix for 10.5 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code only consider condition Slave_SQL_Running is yes and then send slave_running equal 1. We should consider both of condition are Slave_IO_Running and Slave_SQL_Running to set the value of slave_running metric.
Improve slave_running check
This change will add the database size (db_size) metric.
Add database size metric
Use gauge instead of counter for db_size metric.
Modify metric type for db_size metric
This reverts commit 6abeec1.
This is done to collect the os_log_bytes_written metric from infromation_schema.metrics table.
The innodb_metrics table is only available since MySQL 5.6 and MariaDB 10.x. This change will prevent this part of the code to raise an error for the MySQL < 5.6 and MariaDB < 10.x.
Add number proccess locked by an other one
Update README.md to add more details about the new lock metrics.
Update README.md to handle the metadata lock
Add read_only metric to detect is a server is in "read-only" mode.
* Add read_only metric Add read_only metric to detect is a server is in "read-only" mode. * Add metric type to make it work with the previous change Co-authored-by: Charles JUDITH <[email protected]>
This will make a code with a 4 spaces tab space. Co-authored-by: Charles JUDITH <[email protected]>
- Line too long - Invalid whitespace - Bad import order
Replace MySQLdb by pymysql. Co-authored-by: Charles JUDITH <[email protected]>
Improve the management of the ON/OFF values in fetch_mysql_variables. This is currently applicable for MYSQL variables only. For example: read_only=OFF will be read_only=0 The previous review on that was only for the read_only variable, this will add it for all other variables. Co-authored-by: Charles JUDITH <[email protected]>
This change will add: - The number of current connections per user - Apply linter Co-authored-by: Charles JUDITH <[email protected]>
Prepare the code to be tested with flake8.
Add python tests with Github Actions
Remove unexisting python 3.4
- Change metric name connections_per_user by user_connections - Reduce metric name - Reduce username field
The Innodb_max_trx_id status variable was re-introduced in 10.5 but Innodb_purge_trx_id was not, causing fetch_mysql_status() to crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Innodb_max_trx_id has reappeared in 10.5 but not Innodb_purge_trx_id.
This causes a Key error in fetch_mysql_status()