Some minor changes you may want to consider #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiyah, I was wanting to pull your repo into another project, but ran into a few minor issues.
i) Some sort of 'partial' sub-module for one of the external dependencies
ii) A reference to kiwi (and simplify) neither of which are required as far as I can tell
iii) A broken test
iv) node-git currently relies on 'absolute' requires rather than relative ones.. This means that in order to use the library it either has to be loaded with a package manager (fine) or have a path to it 'unshifted' in the app. By changing the paths to be relative the unshift is no longer required. This may be preferable to some people :)
The pull request hopefully contains a commit for each of these tiny problems, hope it helps :)