Make regex ending slightly smarter #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can match match words ending with chars that do not constitute words boundaries like stigm@ Closes chrisvfritz#5
Author
|
@chrisvfritz this change doesn't seem to break any more tests from the current suite (there was already one failing test). I'd gladly straighten things up (maybe even add some test cases) if you think it'd be necessary and this to be a desirable change. For me it'd be awesome to have this use case contemplated. |
Owner
|
@embs Are you interested in simply becoming the new owner of this gem? Then you could make additional adjustments and publish new versions without having to go through me. It's been a few years since I've had need for it, so I think it may be time to pass on the baton. |
|
@chrisvfritz We still use the gem and need changes, I could take this on if @embs doesn't want to. |
|
@chrisvfritz Any thoughts on that? ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can match match words ending with chars that do not constitute
words boundaries like
Closes #5