fix: block server owner from leaving without transferring ownership (#178)#179
Open
yashrajpurohit7 wants to merge 1 commit into
Open
fix: block server owner from leaving without transferring ownership (#178)#179yashrajpurohit7 wants to merge 1 commit into
yashrajpurohit7 wants to merge 1 commit into
Conversation
Contributor
|
@yashrajpurohit7 is attempting to deploy a commit to the Sunil Kumar's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
@yashrajpurohit7 Can you please resolve merge conflicts |
yashrajpurohit7
force-pushed
the
fix/prevent-owner-leaving-server
branch
from
2b64ac2 to
edab6be
Compare
|
Hey @yashrajpurohit7! Saw your work on GSSoC 2026. We are building TermUI, a TypeScript terminal UI framework with React-style hooks and JSX, rendered entirely in the terminal. We have 67 unassigned GSSoC issues open. 19 are marked Karanjot, TermUI maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #178
The leave_server endpoint had no role check - server owners
could leave just like regular members, making the server
permanently ownerless.
What I changed:
Added a role check before the leave logic runs. It queries the
user's servers array to find their role for that specific server.
Three cases are now handled:
transfer ownership first
soft deleted automatically
The role and member count data was already in the DB
it just wasn't being checked anywhere in this route.
Files changed :