fix(socket): require authenticated realtime sessions#190
Open
saurabhhhcodes wants to merge 1 commit into
Open
Conversation
Contributor
|
@saurabhhhcodes is attempting to deploy a commit to the Sunil Kumar's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_userid/ friend-request sender claims that do not match the authenticated userRelated Issue
Closes #145
Type of Change
Validation
cd server && node --check src/socket/index.js && node --check scripts/run-socket-auth-unit.mjs && npm run test:socket:authcd frontend && npm run lintcd frontend && npm run buildgit diff --checkNotes for Reviewers
There is an older stale PR #60 that attempted similar socket auth work against
server/socket/index.js, but that path is not the active socket module on currentmain. This PR applies the fix to the liveserver/src/socket/index.jsimplementation referenced in #145 and keeps the frontend token wiring minimal.