Repository navigation
Add PyPI trusted-publishing workflow - #92
Open
gonzalocasas wants to merge 3 commits into
Open
gonzalocasas wants to merge 3 commits into
gonzalocasas wants to merge 3 commits into
Conversation
- Add `publish.yml`: builds sdist/wheel and runs `twine check --strict` on every PR/push; on a published GitHub release, verifies the tag matches the package version and uploads to PyPI via trusted publishing. - Fail releases early if the metadata contains direct URL dependencies (e.g. `jaxls @ git+...`), which PyPI rejects at upload. - Single-source the version from `pyroki.__version__`. - Use an SPDX license expression (setuptools>=77), dropping the deprecated license table/classifier. - Add authors, keywords and project URLs to the package metadata. - README: document `pip install pyroki` alongside the source install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`tyro` and `robot_descriptions` are only used by the examples, tests and benchmarks, never by the library itself. Moving them to an `examples` extra slims down `pip install pyroki`, and defines the extra that the CI workflows already install via `.[dev,examples]`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Ignore PLR0917 (too many positional arguments), the positional sibling of the already-ignored PLR0913; newer ruff releases enforce it, and the cost functions take positional arguments on purpose. - Assert only on the exception type in the RobotCollision batching test: JAX 0.12 reworded the pytree mismatch error, which broke the message-based assertion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Open
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90 (once the
jaxlsdependency is sorted out, see below).This adds a release workflow that publishes to PyPI via trusted publishing (no API tokens), plus the packaging fixes needed for a clean first release.
One-time setup
pyroki: ownerchungmin99, repositorypyroki, workflowpublish.yml, environmentpypipypi__version__insrc/pyroki/__init__.py, merge, and publish a GitHub release taggedv<version>.Blocker:
jaxlspyrokidepends on a git branch ofjaxlsand that's not allowed in the publishing process, sojaxlsneeds to be published first, beforepyrokican be released to pypi