Skip to content

promise-race/all take just promise list #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

promise-race/all take just promise list #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9813e9b
promise-race take just promise list
conao3 Mar 5, 2021
8a9e128
promise-all take just promise list
conao3 Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions promise-es6-extensions.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@
(t
(promise--value value))))

(defun promise-all (arr)
(let ((args (cl-coerce arr 'vector)))
(defun promise-all (&rest arr)
(let ((args (cl-coerce (if (promise-class-p (car arr)) arr (car arr)) 'vector)))

(promise-new
(lambda (resolve reject)
Expand Down Expand Up @@ -149,12 +149,13 @@
(promise-new (lambda (_resolve reject)
(funcall reject value))))

(defun promise-race (values)
(promise-new (lambda (resolve reject)
(cl-loop for value across (cl-coerce values 'vector)
do (promise-then (promise-resolve value)
resolve
reject)))))
(defun promise-race (&rest values)
(let ((values* (if (promise-class-p (car values)) values (car values))))
(promise-new (lambda (resolve reject)
(cl-loop for value across (cl-coerce values* 'vector)
do (promise-then (promise-resolve value)
resolve
reject))))))

(cl-defmethod promise-catch ((this promise-class) on-rejected)
(promise-then this nil on-rejected))
Expand Down