Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to override defaults in config #1034

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mansona
Copy link
Contributor

@mansona mansona commented Dec 4, 2017

This is only a proof of concept to see if you are happy with the idea, and if so we can extend it to all/any of the parameters you want to be able to set the defaults for in config.

The basic idea here is: you have a sensible default set for matchTriggerWidth on ember-power-select but I need this default to be different for all instances of ember-power-select across my codebase.

Using a trick similar to we use in ember-cli-notifications I have been able to test this locally with a linked ember-power-select. If you like the idea I can (try) implement some tests using https://github.com/tomdale/ember-cli-addon-tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant