Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 1057 - component tag rendering twice #1206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpirio
Copy link

@mpirio mpirio commented Mar 1, 2019

cf #1057

When we set a tagName on a power-select-multiple, this tag is rendering twice because tagName is set for power-select-multiple but it is transmit to power-select also. I removed class too.

improvment idea: Perhaps could we set a default "div" tagName when a class is setted?

@cibernox
Copy link
Owner

cibernox commented Mar 1, 2019

If you only pass class right now, doesn't that give you a single div already?

@mpirio
Copy link
Author

mpirio commented Mar 4, 2019

@cibernox I tested with last version 2.2.2: no 'div' is added automatically if we define a class.

@mpirio
Copy link
Author

mpirio commented May 13, 2019

@cibernox what do you think about this PR? ;) Thanks

@cibernox
Copy link
Owner

Sorry, I forgot about this. Checking

@cibernox
Copy link
Owner

I have an alternative solution that I think it's more aligned with the future in which components are tagless by default, and it's not a breaking change today.

The problem is that since tagName has a meaning for components, is applied to both elements, which only the internal one should have it. The multiple should only be a wrapper.

I suggest that the way to customize the tag of a multiple-select will be now htmlTag. Internally you pass tagName=(or tagName htmlTag) to EPS. That makes it backwards compatible. And you don't need to touch class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants