-
Notifications
You must be signed in to change notification settings - Fork 36
Add proposal for CiliumEndpointSlice stabilization #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
thorn3r
wants to merge
1
commit into
cilium:main
Choose a base branch
from
thorn3r:CESgraduation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
# CFP-31904: CiliumEndpointSlice Graduation to Stable | ||
|
||
**SIG: sig-scalability** | ||
|
||
**Begin Design Discussion:** 2024-04-11 | ||
|
||
**Cilium Release:** 1.16 | ||
|
||
**Authors:** Tim Horner <[email protected]>, Marcel Zięba <[email protected]>, Marco Iorio <[email protected]> | ||
|
||
## Summary | ||
|
||
CiliumEndpointSlice facilitates the grouping of multiple CiliumEndpoint objects to achieve better scalability. This document describes the remaining work needed to consider CiliumEndpointSlice a Stable feature. | ||
|
||
## Goals | ||
|
||
* Blanket test CiliumEndpointSlice in all CI workflows. | ||
- CiliumEndpointSlice will be temporarily enabled for all CI workflows to identify failures or feature incompatibilities. The goal of the blanket test is to provide guidance on areas of improvement to focus on and any gaps in tooling. | ||
|
||
* Enable CiliumEndpointSlice in CI tests. | ||
- The feature has unit test coverage but there is no end-to-end testing. CiliumEndpointSlice will be enabled in the Conformance E2E and 100 Nodes Scale Test workflows. Additional workflows may be added based on the findings of the blanket test. | ||
|
||
* Identify feature incompatibilites | ||
- Identify features that rely on the use of CiliumEndpoint and summarize the work needed to support CiliumEndpointSlice. A decision should be made per-feature whether the incompatibility should be fixed or documented. The decision should be made based on the amount of work needed and the value add of making the feature compatible with CiliumEndpointSlice. | ||
* Simplify CiliumEndpointSlice configuration | ||
- Cilium Operator accepts the following 8 options for configuring CiliumEndpointSlice: | ||
- ces-max-ciliumendpoints-per-ces | ||
- ces-slice-mode | ||
- ces-write-qps-limit | ||
- ces-write-qps-burst | ||
- ces-enable-dynamic-rate-limit | ||
- ces-dynamic-rate-limit-nodes | ||
- ces-dynamic-rate-limit-qps-limit | ||
- ces-dynamic-rate-limit-qps-burst | ||
|
||
- Configuration should be simplified by setting sane defaults and removing any unused or deprecated options. CiliumEndpointSlice should use its own Kubernetes ClientSet to decouple it from the ClientSet used by the CiliumOperator for all other resources. | ||
|
||
* Define a migration path from CiliumEndpoint to CiliumEndpointSlice | ||
- A migration path is needed to allow users to enable CiliumEndpointSlice on clusters utilizing CiliumEndpoint. The process should be simple and well documented, with CI test coverage to identify regressions. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.