[ONPREM-2536] Fix child process cleanup on Windows #212
+98
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-stephen
force-pushed
the
cs/flaky-zombie-test
branch
from
628c811 to
daf3b07
Compare
christian-stephen
force-pushed
the
cs/flaky-zombie-test
branch
from
6badcbb to
9346723
Compare
| pidCmd := "echo $$ >" | ||
| if runtime.GOOS == "windows" { | ||
| // https://stackoverflow.com/a/77115597 | ||
| pidCmd = "ps -p $$ | awk 'NR ==2{print $4}' >" |
There was a problem hiding this comment.
This test was flaky since we weren't getting the PID correctly, so the lookup for lingering child processes "incorrectly" failed.
| } | ||
|
|
||
| func (c *Command) start() error { | ||
| g, err := newProcessExitGroup() |
There was a problem hiding this comment.
christian-stephen
force-pushed
the
cs/flaky-zombie-test
branch
from
9346723 to
4179307
Compare
christian-stephen
changed the title
atulsingh0
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ Issue
https://circleci.atlassian.net/browse/ONPREM-2536
⚙️ Change Description
There was a bug on Windows in the test to check for lingering child processes after task agent terminates. Once this test was fixed, it was revealed that child processes weren't getting destroyed as expected. This updates the
cmdpackage to set up a job object for the task agent prcoess and its children so that they will destroyed accordingly.Acceptance Criteria:
✅ Solution
❓ Testing
📖 Documentation Updates