fix: verify credit top-ups on-chain and bind claims to payer - #60
Open
kutluhaneth46 wants to merge 1 commit into
Open
fix: verify credit top-ups on-chain and bind claims to payer#60kutluhaneth46 wants to merge 1 commit into
kutluhaneth46 wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
credits/usdcAmount/destinationAddressonPOST /api/transactions(unlimited credit mint).ADMIN_WALLET_ADDRESSoradmin_wallets, same source as/api/destination-wallet).Transferlog (bigint micro-USDC; rate matches the purchase UI: 1 USDC = 1 credit).personal_signclaim overbuildTopupClaimMessage(chainId, txHash)from the paying wallet so another authenticated session cannot claim a victim's payment.5042002) via the sample RPC default; other chains via optionalRPC_URL_*env vars.Related discussion on #56 (same problem; this closes the recipient override and cross-session claim holes called out there).
Test plan
txHashfrom a second account session → 409 / no creditdestinationAddressin body → ignored; only admin wallet Transfer matchesRPC_URL_*→ 400 Unsupported chain