Skip to content

Reject amount strings with trailing or invalid characters #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bornoz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reject amount strings with trailing or invalid characters #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/utils/amount.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,16 @@ export const parseAmount = (amountStr: string): number => {
.replace(/[$€£,\s]/g, "")
.replace(/−/g, "-");

// Parse the amount
// The cleaned string must be a plain decimal in its entirety. parseFloat
// accepts a valid numeric prefix and ignores the rest, so "10abc" would parse
// as 10 and "1e5" as 100000 — both silently altering a monetary value.
if (!/^\d+(\.\d+)?$/.test(cleanAmount)) {
throw new Error(`Invalid amount: ${amountStr}`);
}

const amount = parseFloat(cleanAmount);

if (Number.isNaN(amount) || amount <= 0) {
if (amount <= 0) {
throw new Error(`Invalid amount: ${amountStr}`);
}

Expand Down