fix: reduce SLOADs and remove dead code in TokenMessenger - #115
Open
Alicepoltora wants to merge 1 commit into
Open
Alicepoltora wants to merge 1 commit into
Alicepoltora wants to merge 1 commit into
Conversation
1. _getLocalMinter(): cache localMinter in a local variable to avoid reading storage twice (require check + return). 2. removeRemoteTokenMessenger(): read remoteTokenMessengers[domain] once into a local variable instead of twice (require check + emit). 3. _isLocalMessageTransmitter(): remove dead immutable check address(localMessageTransmitter) != address(0). The immutable is set in the constructor with a require(non-zero) guard, so this condition is always true. Fixes circlefin#112
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #112
1.
_getLocalMinter()— cache SLOADRead
localMinterinto a local variable before therequirecheck. Avoids reading storage twice (once for the check, once for the return).2.
removeRemoteTokenMessenger()— cache SLOADRead
remoteTokenMessengers[domain]into a local variable first, then use it for both therequirecheck and theemit. Avoids a redundant SLOAD.3.
_isLocalMessageTransmitter()— remove dead immutable checkRemoved
address(localMessageTransmitter) != address(0). ThelocalMessageTransmitterimmutable is set in the constructor with arequire(non-zero)guard — it can never be zero. The check always evaluates totrueand wastes gas on every call.