[DNM for discussion] Conditionally change button text on USB connect. Resolves #328 #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the text in the UI button for selecting a filesystem mount point based on platform. Putting the pathname on the filesystem could be confusing for Windows or ChromeOS users where they don't have the concept of a single filesystem tree the way *NIX filesystems are used to.
|
I'm puting up this change mostly just to start a discussion. Do we want the pathname in this button? For example, on ChromeOS and Windows we could just make it say "OK" but then, users who don't dig down in the filesystem might be confused by the path that comes up. FYI, I have only tested sucessfully on my windows laptop at home. I'm wondering what it shows on a Mac? Underneath it all is a single UNIX filesystem, but users that don't use the shell don't see that. |
ericzundel
changed the title
ericzundel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the text in the UI button for selecting a filesystem mount point based on platform. Putting the pathname on the filesystem could be confusing for Windows or ChromeOS users where they don't have the concept of a single filesystem tree the way *NIX filesystems are used to.
Resolves #328