Skip to content

[DNM for discussion] Conditionally change button text on USB connect. Resolves #328 #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ericzundel
Copy link

@ericzundel ericzundel commented Jul 12, 2025

Changes the text in the UI button for selecting a filesystem mount point based on platform. Putting the pathname on the filesystem could be confusing for Windows or ChromeOS users where they don't have the concept of a single filesystem tree the way *NIX filesystems are used to.

image

Resolves #328

 - Change the text in the UI button for selecting a filesystem
   mount point based on platform.  Putting the pathname on the
   filesystem could be confusing for Windows or ChromeOS users
   where they don't have the concept of a single filesystem
   tree the way *NIX filesystems are used to.
@ericzundel
Copy link
Author

I'm puting up this change mostly just to start a discussion. Do we want the pathname in this button? For example, on ChromeOS and Windows we could just make it say "OK" but then, users who don't dig down in the filesystem might be confused by the path that comes up.

FYI, I have only tested sucessfully on my windows laptop at home. I'm wondering what it shows on a Mac? Underneath it all is a single UNIX filesystem, but users that don't use the shell don't see that.

@ericzundel ericzundel changed the title Conditionally change button text on USB connect [DNM for discussion] Conditionally change button text on USB connect. Issue#328 Jul 12, 2025
@ericzundel ericzundel changed the title [DNM for discussion] Conditionally change button text on USB connect. Issue#328 [DNM for discussion] Conditionally change button text on USB connect. Resolves #328 Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor UI issue: On windows, connecting to filesystem shows filesystem path as "/"
1 participant