-
Notifications
You must be signed in to change notification settings - Fork 1
Second Addition Virtual Mainline #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sahil-kale
wants to merge
2
commits into
main
Choose a base branch
from
second-addition-mainline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
typedef struct { | ||
float measured_current_A; // Measured current in Amperes | ||
float commanded_bus_voltage_V; // Commanded bus voltage in Volts | ||
float motor_speed_rad_per_s; // Motor speed in radians per second from encoder | ||
} motor_input_data_t; | ||
|
||
typedef struct { | ||
motor_input_data_t input_data; | ||
bool is_stalled; // True if the motor is stalled, false otherwise | ||
// Additional variables can be added as needed | ||
} motor_handle_t; | ||
|
||
/** | ||
* @brief Function to be called every 1 ms for motor stall detection | ||
* @param motor Pointer to the motor handle structure | ||
*/ | ||
void motor_stall_detect_period_run_1ms(motor_handle_t *motor); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
\documentclass[main.tex]{subfiles} | ||
|
||
\begin{document} | ||
\section{Suppose a DC motor is connected to a load - how would you detect a stalled-rotor condition?} | ||
Assume the header in Listing \ref{code:motor-stall-header} is provided. Discuss the implementation of stalled-rotor detection in the following circumstances: | ||
\begin{itemize} | ||
\item The DC motor features only a current sensor. | ||
\item The DC motor features only an encoder. | ||
\end{itemize} | ||
|
||
\lstinputlisting[caption={Motor Stall Detection Header}, label={code:motor-stall-header}]{code/motor_stall/motor_stall_header.h} | ||
|
||
\spoilerline | ||
|
||
|
||
\end{document} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,12 @@ | ||||||
\documentclass[main.tex]{subfiles} | ||||||
\begin{document} | ||||||
|
||||||
\begin{center} | ||||||
------------ \textbf{2nd Edition} ------------ | ||||||
\end{center} | ||||||
|
||||||
\section{What's new in the 2nd Edition?} | ||||||
After receiving feedback from readers of the first edition, we've added a couple more new questions and answers from what people felt were missing topics. We hope you enjoy the new content and as always, please reach out with any feedback or suggestions for future editions! \bluehref{Form link to connect with us.}{https://circuits-and-code.github.io/connect/} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] The link text “Form link to connect with us.” is unclear and grammatically awkward; consider rephrasing to something like “Fill out our form to connect with us.” for better readability.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
|
||||||
|
||||||
\end{document} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Avoid hardcoding dashed lines; consider using LaTeX constructs like \hrulefill or \rule to draw a horizontal line, which improves consistency and makes future styling easier.
Copilot uses AI. Check for mistakes.