minor improvements and drafting new sections #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@sahil-kale Are the changes to the vscode settings.json breaking anything? I'm not sure what's actually changing there. |
Member
Shoooould be fine, worst case i'll revert |
Member
|
also imma have copilot take a first pass hehe |
sahil-kale
reviewed
Jan 4, 2026
Comment on lines
+6
to
+10
| <<<<<<< HEAD | ||
| \noindent State any assumptions regarding component values. These questions are similar to Section \ref{section:passives}. % These questions are more complex then those given in Section \ref{section:passives}, but are fun to consider. | ||
| ======= | ||
| \noindent State any assumptions regarding component values. These questions are more complex than those given in Section \ref{section:passives}, but are fun to consider. | ||
| >>>>>>> origin/main |
Member
There was a problem hiding this comment.
seems like more as well sprinkled throughout
There was a problem hiding this comment.
Pull request overview
This pull request introduces minor improvements to existing documentation and drafts two new sections on unknown capacitors and transmission lines. The changes include punctuation corrections, spelling fixes, comment updates, and copyright year updates.
Key Changes:
- Added two new draft sections:
unknown_capacitor.texandtransmission_lines.texwith theoretical content on capacitance measurement and coaxial cable length determination - Updated copyright year from 2025 to 2026 and revised author biography in preamble
- Enhanced content in
switching.texwith expanded discussion of MOSFETs, high-side vs. low-side switching, and follow-up questions
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
src/voltage_divider.tex |
Changed period to colon for improved punctuation consistency |
src/unknown_capacitor.tex |
New draft section on determining capacitance of unknown discrete capacitors using RC time domain, constant current, and LC resonance methods |
src/transmission_lines.tex |
New draft section on measuring coaxial cable length covering transmission line theory, characteristic impedance, and scattering parameters |
src/switching.tex |
Expanded transistor discussion, added high-side vs. low-side switching comparison, and included follow-up questions; contains unresolved merge conflicts |
src/preamble.tex |
Updated author biography and copyright year to 2026 |
src/passives.tex |
Added explanatory comments and refined follow-up questions |
src/oscilloscope.tex |
Changed "AC vs DC" to "AC versus DC" for consistency |
src/main.tex |
Standardized comment formatting with colons and added TODO notes for incomplete sections |
src/led.tex |
Contains unresolved merge conflict in PWM section |
src/diagram_generator/hpf_bode_plot.py |
Updated title to use "vs." instead of "vs" |
src/diagram_generator/ac_dc.py |
Updated title and removed TODO comment |
src/current_sense.tex |
Fixed spelling of "necessary" and expanded follow-up question |
src/buck_vs_ldo.tex |
Contains unresolved merge conflict and improved technical accuracy of MOSFET description |
src/appendix_more_passives.tex |
Contains unresolved merge conflict in introductory text |
.vscode/settings.json |
Reformatted JSON structure and added C/C++ runner configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+128
to
+130
| ======= | ||
| \noindent When $I_L \approx 0$ the switch node voltage, $V_{sw}$, begins to oscillate with a peak of $\approx V_{out} \cdot 2$ converging towards $V_{out}$.\footnote{If the oscillation was undamped, it would have a peak of exactly $V_{out} \cdot 2$ and would not decrease in amplitude over time. In this case, damping is mostly provided by the parasitic resistance of the inductor.} This is because when $I_L \approx 0$, $V_{sw} = 0$ and $V_{out} \neq 0$ which means current will begin to flow through the inductor into the parasitic capacitance, $C_{parasitic}$, that exists between $V_{sw}$ and ground. This small resonant current, $I_L$, results in a noticeable voltage fluctuation on $V_{sw}$, but not on $V_{out}$ because $C_{out} >> C_{parasitic}$ (where $C_{out}$ is the output capacitance of the buck converter). | ||
| >>>>>>> origin/main |
There was a problem hiding this comment.
Merge conflict markers are present in the code. These need to be resolved before merging. Choose one version of the text (either HEAD or origin/main) and remove the conflict markers.
Suggested change
| ======= | |
| \noindent When $I_L \approx 0$ the switch node voltage, $V_{sw}$, begins to oscillate with a peak of $\approx V_{out} \cdot 2$ converging towards $V_{out}$.\footnote{If the oscillation was undamped, it would have a peak of exactly $V_{out} \cdot 2$ and would not decrease in amplitude over time. In this case, damping is mostly provided by the parasitic resistance of the inductor.} This is because when $I_L \approx 0$, $V_{sw} = 0$ and $V_{out} \neq 0$ which means current will begin to flow through the inductor into the parasitic capacitance, $C_{parasitic}$, that exists between $V_{sw}$ and ground. This small resonant current, $I_L$, results in a noticeable voltage fluctuation on $V_{sw}$, but not on $V_{out}$ because $C_{out} >> C_{parasitic}$ (where $C_{out}$ is the output capacitance of the buck converter). | |
| >>>>>>> origin/main | |
| \noindent When $I_L \approx 0$ the switch node voltage, $V_{sw}$, begins to oscillate with a peak of $\approx V_{out} \cdot 2$ converging towards $V_{out}$.\footnote{If the oscillation was undamped, it would have a peak of exactly $V_{out} \cdot 2$ and would not decrease in amplitude over time. In this case, damping is mostly provided by the parasitic resistance of the inductor.} This is because when $I_L \approx 0$, $V_{sw} = 0$ and $V_{out} \neq 0$ which means current will begin to flow through the inductor into the parasitic capacitance, $C_{parasitic}$, that exists between $V_{sw}$ and ground. This small resonant current, $I_L$, results in a noticeable voltage fluctuation on $V_{sw}$, but not on $V_{out}$ because $C_{out} >> C_{parasitic}$ (where $C_{out}$ is the output capacitance of the buck converter). |
| \begin{itemize} | ||
| \item Ensure your method can determine the capacitance at any given DC bias voltage. | ||
| \item Using a tool with a direct capacitor meter (i.e. Digital Multimeter (DMM), LC Meter, Vector Network Analyzer (VNA)) is not permitted. Consider using a bench-top power supply, components of known values, and the oscilloscope only. % Force a solution based on first principles instead of "connect it to a DMM in capacitance reading mode..." | ||
| \item Assume the capacitance is known to be larger than $1 \mu H$. % avoid the RF implications of this question mostly |
There was a problem hiding this comment.
The unit should be microfarad (µF) not microhenry (µH). Capacitance is measured in farads, not henries. Henries are the unit for inductance.
Suggested change
| \item Assume the capacitance is known to be larger than $1 \mu H$. % avoid the RF implications of this question mostly | |
| \item Assume the capacitance is known to be larger than $1 \mu F$. % avoid the RF implications of this question mostly |
| \subfile{appendix_more_passives.tex} | ||
| \newpage | ||
| \subfile{appendix_more _opamps.tex} | ||
| \subfile{appendix_more _opamps.tex} % TODO FIX : I put a space in this filename on accident .... at some point fix this plz |
There was a problem hiding this comment.
There's an extra space in the filename "appendix_more _opamps.tex" (space before underscore in "_opamps"). This makes the filename inconsistent with other files and could cause issues. The TODO comment acknowledges this error but the file should be renamed or the reference should be fixed to match the actual filename.
Suggested change
| \subfile{appendix_more _opamps.tex} % TODO FIX : I put a space in this filename on accident .... at some point fix this plz | |
| \subfile{appendix_more_opamps.tex} % TODO FIX : I put a space in this filename on accident .... at some point fix this plz |
| \begin{itemize} | ||
| \item If multiple load devices are present, it is likely all of them need ground while they could require different voltage level power sources. By performing high side switching the total number of wires required in the harness could be decreased. For automotive applications the chassis also serves as ground meaning a low impedance ground connection to peripherals can come for free. | ||
| \item If a load requires a higher voltage and ground is prevelant then having high voltage always connected to the harness to the load exposes humans to a risk even when they preseive the load as unpowerred as the human can touch the high voltage harness and the chassis to receive a shock even whehn the load is not powerred. | ||
| \item Low side switching is the easiest bc % TODO write -> % The primary advantage of low side switching is that it is easier to switch a transistor on the low side rather than the high side. % Also lower conduction losses by using an NMOS |
There was a problem hiding this comment.
This sentence is incomplete and ends with "bc % TODO write". This should be completed before merging or the entire bullet point should be temporarily removed until it's ready.
Suggested change
| \item Low side switching is the easiest bc % TODO write -> % The primary advantage of low side switching is that it is easier to switch a transistor on the low side rather than the high side. % Also lower conduction losses by using an NMOS | |
| \item Low side switching is often preferred because it is easier to drive the low-side NMOS from a low-voltage microcontroller and it offers lower conduction losses by using an NMOS device. |
|
|
||
| \section{How would you determine the length of an unknown coaxial cable?} \label{section:Transmission_lines} | ||
|
|
||
| You cannot using a mechanical measurement device (i.e. measuring tape, ruler, etc.). |
There was a problem hiding this comment.
Missing period at the end of this sentence. The sentence should end with proper punctuation.
Suggested change
| You cannot using a mechanical measurement device (i.e. measuring tape, ruler, etc.). | |
| You cannot use a mechanical measurement device (i.e. measuring tape, ruler, etc.). |
| % think of high voltage, switching neutral would make unscrewing a lightbulb unsafe | ||
| \begin{itemize} | ||
| \item If multiple load devices are present, it is likely all of them need ground while they could require different voltage level power sources. By performing high side switching the total number of wires required in the harness could be decreased. For automotive applications the chassis also serves as ground meaning a low impedance ground connection to peripherals can come for free. | ||
| \item If a load requires a higher voltage and ground is prevelant then having high voltage always connected to the harness to the load exposes humans to a risk even when they preseive the load as unpowerred as the human can touch the high voltage harness and the chassis to receive a shock even whehn the load is not powerred. |
There was a problem hiding this comment.
There's a typo: "powerred" should be spelled "powered" (one 'r').
Suggested change
| \item If a load requires a higher voltage and ground is prevelant then having high voltage always connected to the harness to the load exposes humans to a risk even when they preseive the load as unpowerred as the human can touch the high voltage harness and the chassis to receive a shock even whehn the load is not powerred. | |
| \item If a load requires a higher voltage and ground is prevalent, then having high voltage always connected to the harness to the load exposes humans to a risk even when they perceive the load as unpowered, as the human can touch the high-voltage harness and the chassis to receive a shock even when the load is not powered. |
| % think of high voltage, switching neutral would make unscrewing a lightbulb unsafe | ||
| \begin{itemize} | ||
| \item If multiple load devices are present, it is likely all of them need ground while they could require different voltage level power sources. By performing high side switching the total number of wires required in the harness could be decreased. For automotive applications the chassis also serves as ground meaning a low impedance ground connection to peripherals can come for free. | ||
| \item If a load requires a higher voltage and ground is prevelant then having high voltage always connected to the harness to the load exposes humans to a risk even when they preseive the load as unpowerred as the human can touch the high voltage harness and the chassis to receive a shock even whehn the load is not powerred. |
There was a problem hiding this comment.
There's a typo: "whehn" should be spelled "when".
Suggested change
| \item If a load requires a higher voltage and ground is prevelant then having high voltage always connected to the harness to the load exposes humans to a risk even when they preseive the load as unpowerred as the human can touch the high voltage harness and the chassis to receive a shock even whehn the load is not powerred. | |
| \item If a load requires a higher voltage and ground is prevelant then having high voltage always connected to the harness to the load exposes humans to a risk even when they preseive the load as unpowerred as the human can touch the high voltage harness and the chassis to receive a shock even when the load is not powerred. |
|
|
||
| \section{How would you determine the length of an unknown coaxial cable?} \label{section:Transmission_lines} | ||
|
|
||
| You cannot using a mechanical measurement device (i.e. measuring tape, ruler, etc.). |
There was a problem hiding this comment.
Grammatical error: "cannot using" should be "cannot use" or "cannot be using". The verb form is incorrect.
Suggested change
| You cannot using a mechanical measurement device (i.e. measuring tape, ruler, etc.). | |
| You cannot use a mechanical measurement device (i.e. measuring tape, ruler, etc.). |
Comment on lines
+124
to
+130
| <<<<<<< HEAD | ||
| \noindent Note that PWM's application is not limited to LEDs - in a general, simplified manner, PWM can be thought of as a way to control the average voltage or current across a load, and is used in motor control, power supplies, and more. | ||
| % See notes for possible future question about RMS vs. AVG voltage where we could explore more of the complexities. This simplification is permissible for now. | ||
| ======= | ||
| \noindent Note that PWM's application is not limited to LEDs---in a general, simplified manner, PWM can be thought of as a way to control the average voltage or current across a load, and is used in motor control, power supplies, and more. | ||
| % See notes for second edition about RMS vs AVG voltage where we could explore more of the complexities. This simplification is permissible for now. | ||
| >>>>>>> origin/main |
There was a problem hiding this comment.
Merge conflict markers are present in the code. These need to be resolved before merging. Choose one version of the text (either HEAD or origin/main) and remove the conflict markers.
Suggested change
| <<<<<<< HEAD | |
| \noindent Note that PWM's application is not limited to LEDs - in a general, simplified manner, PWM can be thought of as a way to control the average voltage or current across a load, and is used in motor control, power supplies, and more. | |
| % See notes for possible future question about RMS vs. AVG voltage where we could explore more of the complexities. This simplification is permissible for now. | |
| ======= | |
| \noindent Note that PWM's application is not limited to LEDs---in a general, simplified manner, PWM can be thought of as a way to control the average voltage or current across a load, and is used in motor control, power supplies, and more. | |
| % See notes for second edition about RMS vs AVG voltage where we could explore more of the complexities. This simplification is permissible for now. | |
| >>>>>>> origin/main | |
| \noindent Note that PWM's application is not limited to LEDs---in a general, simplified manner, PWM can be thought of as a way to control the average voltage or current across a load, and is used in motor control, power supplies, and more. | |
| % See notes for second edition about RMS vs AVG voltage where we could explore more of the complexities. This simplification is permissible for now. |
| % think of high voltage, switching neutral would make unscrewing a lightbulb unsafe | ||
| \begin{itemize} | ||
| \item If multiple load devices are present, it is likely all of them need ground while they could require different voltage level power sources. By performing high side switching the total number of wires required in the harness could be decreased. For automotive applications the chassis also serves as ground meaning a low impedance ground connection to peripherals can come for free. | ||
| \item If a load requires a higher voltage and ground is prevelant then having high voltage always connected to the harness to the load exposes humans to a risk even when they preseive the load as unpowerred as the human can touch the high voltage harness and the chassis to receive a shock even whehn the load is not powerred. |
There was a problem hiding this comment.
There's a typo: "preseive" should be spelled "perceive".
Suggested change
| \item If a load requires a higher voltage and ground is prevelant then having high voltage always connected to the harness to the load exposes humans to a risk even when they preseive the load as unpowerred as the human can touch the high voltage harness and the chassis to receive a shock even whehn the load is not powerred. | |
| \item If a load requires a higher voltage and ground is prevelant then having high voltage always connected to the harness to the load exposes humans to a risk even when they perceive the load as unpowerred as the human can touch the high voltage harness and the chassis to receive a shock even whehn the load is not powerred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.