Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and Update SQS Versions of PE Report Scans #808

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

arng4108
Copy link

@arng4108 arng4108 commented Feb 28, 2025

🗣 Description

Changes were made to update and add several SQS PE report scans:

  • scanExecution.py was updated so that Shodan API keys would be passed in when the asmSync SQS scan runs
  • All the other file changes were made in order to add the SQS versions of P&E Report scans (Cybersixgill alerts/credentials/mentions/topcves and dnsmonitor).

💭 Motivation and context

  • The ASM Sync process needs Shodan API keys to function properly. As a result, small updates were made so that those Shodan keys would be passed into the fargate containers.
  • The PE Report scans are currently running on the Accessor, which is not very scalable. As a result, these updates will add SQS versions of these scans that are more capable of scaling

🧪 Testing

The commands that were added to call the new SQS versions of the PE report scans have been tested and confirmed to be working. The code for the new SQS PE report scans are in the crossfeed-sqs branch of the ATC-Framework repo. Additionally, the scan code that was added to XFD follows a very similar pattern to existing SQS scans so not much new code was needed. These changes should only affect the SQS scans that P&E uses.

📷 Screenshots (if appropriate)

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant