Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Natural Sort to Filter Tags (CRASM-2342) #810

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hawkishpolicy
Copy link
Collaborator

  • Add natural sort to Region ID filter tags.
  • "1", "10", "2" is now "1", "2", "10".

🗣 Description

  • Converted Region ID strings to numbers for sorting.

💭 Motivation and context

  • Closes CRASM-2342

🧪 Testing

  • tested locally

📷 Screenshots (if appropriate)

Screenshot 2025-03-05 at 9 47 26 AM Screenshot 2025-03-05 at 9 47 06 AM

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

- Converted Region ID strings to numbers for sorting.
@hawkishpolicy hawkishpolicy self-assigned this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant