Create ASM sync scan CRASM 2315 #818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add service and domain links to vuln tables
Merge develop into current branch
update mdl models and VS cidr save
mark cidr org relationship to current if updating
delete unnecessary columns in cidr model
Create ASM sync scan & clean up models
Update scan to not run in in LZ
Update scan so it only runs in DMZ or locally
make threading more efficient and remove f strings and run precommit checks/linter
Update Logging to use lazy loading
remove else statement after continue
Check newly found ips against cidr blocks and only add if there is a link
Don't set root_domain as non current if they haven't been seen
Update logging levels to include .info level
Run linter
Make Thread count a environmental variable
Comment out unused update
Remove dangerous default value
DJensen94
requested review from
aloftus23,
cduhn17,
Matthew-Grayson,
nickviola,
rapidray12 and
schmelz21
as code owners
Fix logging issue and environment var import
Don't set user provided roots to not current
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Create scan to enumerate and find new assets and mark existing assets as current or not current.
Scan should only be able to run in the DMZ or in a local testing environment
💭 Motivation and context
This will make asset tracking more robust. And give the end user more visibility into what assets we are tracking and which have been identified
🧪 Testing
Tested locally