Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRASM-2493: Fix deployment bugs: Ensure Jinja2 in lambda and only create crossfeed-lz-sync bucket in DMZ #823

Merged
merged 5 commits into from
Mar 21, 2025
Merged

CRASM-2493: Fix deployment bugs: Ensure Jinja2 in lambda and only create crossfeed-lz-sync bucket in DMZ #823

merged 5 commits into from
Mar 21, 2025

Conversation

aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Mar 21, 2025 •
edited
Loading

🗣 Description

Ensure Jinja2 in lambda and only create crossfeed-lz-sync bucket in DMZ

💭 Motivation and context

Email templates now require Jinja2 in the lambda to run our asgi successfully so need to take it out of the don't install list.

No reason to create extra unneeded buckets.

🧪 Testing

Passes pre-commits and pytests.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@aloftus23 aloftus23 self-assigned this Mar 21, 2025
@aloftus23 aloftus23 marked this pull request as ready for review March 21, 2025 17:22
rapidray12
rapidray12 approved these changes Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly simple

@aloftus23 aloftus23 changed the title Fix deployment bugs: Ensure Jinja2 in lambda and only create crossfeed-lz-sync bucket in DMZ CRASM-2493: Fix deployment bugs: Ensure Jinja2 in lambda and only create crossfeed-lz-sync bucket in DMZ Mar 21, 2025
cduhn17
cduhn17 approved these changes Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cduhn17 cduhn17 merged commit 572a8e9 into develop Mar 21, 2025
18 checks passed
@cduhn17 cduhn17 deleted the AL-deployment-updates branch March 21, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cduhn17 cduhn17 cduhn17 approved these changes

@rapidray12 rapidray12 rapidray12 approved these changes

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees

@aloftus23 aloftus23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aloftus23 @cduhn17 @rapidray12