Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Playwright configuration to have test domain as an environment variable #825

Merged
merged 24 commits into from
Mar 28, 2025
Merged

Change Playwright configuration to have test domain as an environment variable #825

merged 24 commits into from
Mar 28, 2025

Conversation

JCantu248
Copy link
Collaborator

🗣 Description

In the Playwright configuration, change the baseURL value to be assigned via environment variable. This will help facilitate easier times reconfiguring Playwright for local testing outside of Docker.

💭 Motivation and context

This is needed for better security and easier modifications if we want to run the same Playwright project locally for testing.

🧪 Testing

Tested by rerunning Playwright in Docker with the applied changes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

JCantu248 and others added 23 commits January 22, 2025 09:06
@JCantu248
Add new integration test, integration.yml
0d15da6
@jyang2139
vulnerabilities tests
7b7bab4
@jyang2139
fixed tests
21cb495
@jyang2139
put test update
fb459ed
@jyang2139
test
6fe3611
@JCantu248
Add method to return domain, vulnerability uids for other test cases.
41a384c
@jyang2139
updated test for new methods
15c37a7
@JCantu248
Change get_domains, get_vulnerabilities to return entire object, not …
f6ab796 
…just id. Then use that to randomly select an id or search parameter for tests.
@jyang2139
updates to id method
76d2a92
@jyang2139
fixing environment variable
ebd4add
@JCantu248
Merge pull request #774 from cisagov/jy_integration_tests
a083545 
Vulnerabilities integration tests
@JCantu248
Code cleanup for test_vulnerabilities.py.
3df9356
@JCantu248
Testing integration workflow on push.
dc09d63
@JCantu248
Add requirements.txt, changes to test_domains.
bfd732a
@aloftus23
Update integration.yml
17db7c3
@JCantu248
Reverting integration.yml to only on deployment status.
c8454f6
@JCantu248
Merge branch 'JD_integration_tests' of github.com:cisagov/XFD into JD…
6ba373a 
…_Integration_tests
@JCantu248
Merge branch 'develop' into JD_integration_tests
45b81c9
@JCantu248
Merge branch 'develop' of github.com:cisagov/XFD into JD_integration_…
6012cd3 
…tests
@JCantu248
Merge branch 'develop' of github.com:cisagov/XFD into develop
abb21c2
@JCantu248
Merge branch 'develop' of github.com:cisagov/XFD into develop
8e8f3eb
@JCantu248
Turn xfd container hostname into an environment variable.
e281b39
@JCantu248
Remove integration tests and workflows that accidentally made it into…
bacae41 
… the repo.
@JCantu248 JCantu248 added test This issue or pull request adds or otherwise modifies test code frontend labels Mar 22, 2025
@JCantu248 JCantu248 self-assigned this Mar 22, 2025
@JCantu248 JCantu248 marked this pull request as ready for review March 24, 2025 14:14
cduhn17
cduhn17 approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chrtorres
chrtorres approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@chrtorres chrtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JCantu248 JCantu248 merged commit 1092d77 into develop Mar 28, 2025
10 checks passed
@JCantu248 JCantu248 deleted the Playwright_local_testing_changes branch March 28, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloftus23 aloftus23 aloftus23 approved these changes

@cduhn17 cduhn17 cduhn17 approved these changes

@chrtorres chrtorres chrtorres approved these changes

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees

@JCantu248 JCantu248

Labels
frontend test This issue or pull request adds or otherwise modifies test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JCantu248 @aloftus23 @cduhn17 @chrtorres @jyang2139