fix(citizen-scripting-core): fixed ClearTimeout after Wait #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
RedM
yanislgha
force-pushed
the
fix/clear-timeout
branch
from
471b4b3 to
cec5045
Compare
github-actions
bot
added
triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
A ClearTimeout() in another thread or after a wait() has no effect, and the SetTimeout continues to execute.
How is this PR achieving the goal
I basically wrote a function to remove a bookmark directly in the
ScriptHost.cppto manage bookmarks between threads, etc.This PR applies to the following area(s)
FiveM, RedM, Server, ScRT: Lua
Successfully tested on
Game builds: v3258
Platforms: Windows, Linux
Checklist
Fixes issues
fixes #3259