Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Encountered error when expecting config to be initialised when using hook_civicrm_config.
Found due to https://github.com/eileenmcnaughton/nz.co.fuzion.civixero/blob/bfa6ec6e0d1906fe9b96e0d364e6a19d7b453331/Civixero.php#L16
which defines the hook as:
function civixero_civicrm_config(CRM_Core_Config $config) {
Seems like in the D7 code config is initialised but somewhere along the way this didn't make it do D8.
https://docs.civicrm.org/dev/en/latest/hooks/hook_civicrm_config/
Before
hook_civicrm_config is called with null, resulting in a Fatal error if nz.co.fuzion.civixero extension latest version is installed.
After
hook_civicrm_config is called with config object.