Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more dynamic properties #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spalmstr
Copy link

@spalmstr spalmstr commented Jan 5, 2024

Later versions of PHP deprecate having dynamic variables in the class constructors and CiviCRM complains when they are used. This PR allows the 'offending' code to use dynamic variables in the constructors, since, without knowing the code, it is possible that the same variable will have different properties depending on how it is called. Obviously, it would be better to declare them if one knew how it was being used.

Copy link

civibot bot commented Jan 5, 2024

(Standard links)

@civibot civibot bot added the master label Jan 5, 2024
@eileenmcnaughton
Copy link
Contributor

@spalmstr I've been digging a bit on Smarty & looks like we can push through to Smarty 4 - which hopefully doesn't have any remaining php compatibility issues - https://lab.civicrm.org/dev/core/-/issues/4954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants