Skip to content

Fix (linux) overlay problem in kde#1121

Open
vpsone wants to merge 1 commit intocjpais:mainfrom
vpsone:fix-kde-overlay
Open

Fix (linux) overlay problem in kde#1121
vpsone wants to merge 1 commit intocjpais:mainfrom
vpsone:fix-kde-overlay

Conversation

@vpsone
Copy link
Copy Markdown

@vpsone vpsone commented Mar 23, 2026

Before Submitting This PR

Please confirm you have done the following:

If this is a feature or change that was previously closed/rejected:

  • I have explained in the description below why this should be reconsidered
  • I have gathered community feedback (link to discussion below)

Human Written Description

This PR fixes the overlay issue in KDE Plasma. After PR #769, the overlay in KDE Plasma started behaving like a regular window, which prevents it from auto-pasting the response after a recording is finished. I have used v0.7.3 (the last version where the overlay worked correctly) for a long time and have not encountered any stability issues due to the gtk-layer-shell protocol. Here is a video of it:
Screencast_20260323_135432.webm

Here is how it looks after updating to v0.8.0:

image

Related Issues/Discussions

#769

Community Feedback

Testing

Screenshots/Videos (if applicable)

AI Assistance

  • No AI was used in this PR
  • AI was used (please describe below)

If AI was used:

  • Tools used:
  • How extensively:

@vpsone vpsone changed the title Fix overlay problem in kde Fix (linux) overlay problem in kde Mar 23, 2026
@cjpais
Copy link
Copy Markdown
Owner

cjpais commented Mar 23, 2026

Unfortunately this fix cannot be approved because it will break the ability of the app to work on many systems. This is a much worse outcome than just the overlay being broken.

@cjpais cjpais closed this Mar 23, 2026
@vpsone
Copy link
Copy Markdown
Author

vpsone commented Mar 23, 2026

But How I just reversed the changes in this pr #769 .

@cjpais
Copy link
Copy Markdown
Owner

cjpais commented Mar 23, 2026

yeah and you think that PR was not for a reason?! it fixes stability issues from what I remember

please let me know if I am wrong or misguided

@vpsone
Copy link
Copy Markdown
Author

vpsone commented Mar 23, 2026

But I have not faced any issue; only I have to install the gtk-layer-shell dependency in the system. Here is the issue a user can get if they do not have the dependency installed.
image

and here after installing it (v0.7.3)
image

Additionally, PR #769 did not clearly explain the original problem, simply referring to it as a 'stability issue'.

@cjpais
Copy link
Copy Markdown
Owner

cjpais commented Mar 23, 2026

Please go ask in that thread, what the stability issue was in particular.

I'm not willing to trade one issue for another unless it's known across many users that it won't cause a regression.

I understand that there was a regression caused in that change, but a sample size of one especially for Linux is not enough.

@vpsone
Copy link
Copy Markdown
Author

vpsone commented Mar 23, 2026

image But It is already broken in v0.8.0 with two cancel button.

@vpsone
Copy link
Copy Markdown
Author

vpsone commented Mar 23, 2026

If you can provide test build for this pr then I can ask others to test it.

@cjpais cjpais reopened this Mar 23, 2026
@github-actions
Copy link
Copy Markdown

🧪 Test Build Ready

Build artifacts for PR #1121 are available for testing.

Download artifacts from workflow run

Artifacts expire after 30 days.

@vpsone vpsone closed this Mar 23, 2026
@vpsone vpsone reopened this Mar 23, 2026
@vpsone
Copy link
Copy Markdown
Author

vpsone commented Mar 23, 2026

I have tried test build and it is working perfectly.

Screencast_20260323_173620.mp4

@xilec
Copy link
Copy Markdown
Contributor

xilec commented Mar 24, 2026

Tested the fix on my system — overlay works correctly: displays speaking/silence timers properly and doesn't interfere with pasting into the focused window.

My setup:

  • NixOS
  • KDE Plasma 6 / Wayland
  • gtk-layer-shell installed as a dependency

Built and ran from this branch via nix run github:vpsone/Handy/fix-kde-overlay. No stability issues on startup or during use.

@VPS07
Copy link
Copy Markdown

VPS07 commented Mar 25, 2026

I have tested build on fedora 43 kde plasma 6/Wayland and it is working correctly. I am facing no stability issues on startup.

@xilec
Copy link
Copy Markdown
Contributor

xilec commented Mar 28, 2026

Summarizing the current state for visibility:

If anyone on CachyOS or Arch could test this branch, that would help rule out the startup stability issue from #769. Please make sure gtk-layer-shell is installed before testing.
@dadaphl @rogsme @theyonecodes — would any of you be able to give it a try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants