fix: add whisper gpu fallback and compute mode#734
Open
BlindMaster24 wants to merge 1 commit intocjpais:mainfrom
Open
fix: add whisper gpu fallback and compute mode#734BlindMaster24 wants to merge 1 commit intocjpais:mainfrom
BlindMaster24 wants to merge 1 commit intocjpais:mainfrom
Conversation
Author
|
@cjpais Done! |
Author
Author
|
Some GPUs don’t support Vulkan, so Whisper GPU mode can fail to start. This adds a CPU fallback and lets users manually choose CPU mode or auto. |
Author
|
was checked |
Contributor
|
hey @BlindMaster24, thanks for putting this together. before we can review this properly, could you fill out the PR template? we have a lot of open PRs and inflight work right now so following the conventions in specifically we'd need
PRs without the template filled out are unlikely to get accepted. happy to review once that's in place! |
Author
|
@cjpais ? |
Owner
|
@BlindMaster24 I have a lot of code to review, I only have limited time to review things every day |
Author
|
@cjpais Ok, waiting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.