feat: store post-processing API keys in OS keychain#814
Open
VirenMohindra wants to merge 1 commit intocjpais:mainfrom
Open
feat: store post-processing API keys in OS keychain#814VirenMohindra wants to merge 1 commit intocjpais:mainfrom
VirenMohindra wants to merge 1 commit intocjpais:mainfrom
Conversation
move API keys from plaintext settings_store.json into the OS-native credential store (macOS keychain, windows credential manager, linux secret service) via the keyring crate. - add keyring wrapper module for set/get/delete/hint operations - auto-migrate existing plaintext keys on first launch - show masked hint (••••••••xxxx) instead of full key in UI - keys persist per-provider across provider switching
VirenMohindra
force-pushed
the
vm/secure-api-key-storage
branch
from
f02ad46 to
36a2026
Compare
thukabjj
added a commit
to thukabjj/Handy
that referenced
this pull request
Mar 2, 2026
- PR cjpais#477: Graceful handling when no microphone is connected - Validate device config before spawning worker thread - Use HandyError with user-friendly messages and recovery suggestions - PR cjpais#930: Transcription hook for external script processing - Add transcription_hook_enabled and transcription_hook_path settings - Pipe transcription through external scripts for custom processing - PR cjpais#814: Secure API key storage in OS keychain - Add keyring module for macOS Keychain, Windows Credential Manager, Linux Secret Service - Commands: set_api_key, get_api_key, delete_api_key, get_masked_api_key - PR cjpais#455: Text replacements with regex and magic commands - Support literal and regex pattern matching - Magic commands: [date], [time], [datetime] - Import/export functionality for replacement rules - PR cjpais#851: Per-entry post-process button for history - Retroactively post-process transcription history entries - Store post-processed text and prompt used - PR cjpais#618: Wake-word detection for Active Listening trigger - Transcript-based wake phrase detection - Configurable trigger actions, cooldown, and threshold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Submitting This PR
Please confirm you have done the following:
Human Written Description
settings_store.json, which means any process with file read access can read them. this moves them into the OS-native credential store (macOS keychain, windows credential manager, linux secret service) so they're protected at rest. existing keys also get silently migrated on first launch and the UI now shows a masked hint instead of the full keyRelated Issues/Discussions
Community Feedback
Testing
settings_store.jsonno longer contains the key value••••••••xxxxbun run lintandcargo clippypassScreenshots/Videos (if applicable)
AI Assistance
If AI was used: