Remove step prop from VolumeSlider component#944
Open
sscotth wants to merge 1 commit intocjpais:mainfrom
Open
Conversation
Removed the `step` prop from VolumeSlider to use the generic Slider component's default `0.01` step size.
sscotth
changed the title
step prop from VolumeSlider componentstep prop from VolumeSlider component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Submitting This PR
Please confirm you have done the following:
If this is a feature or change that was previously closed/rejected:
Human Written Description
Removed the
stepprop from VolumeSlider to use the generic Slider component's default0.01step size. Currently the volume slider moves in 10% increments only and 10% is too loud for my system.Related Issues/Discussions
Fixes #
Discussion:
Community Feedback
Testing
Local development build
Screenshots/Videos (if applicable)
AI Assistance
If AI was used: