feat: add MIDI trigger binding as an additional transcription input#960
Closed
lucinadin wants to merge 1 commit intocjpais:mainfrom
Closed
feat: add MIDI trigger binding as an additional transcription input#960lucinadin wants to merge 1 commit intocjpais:mainfrom
lucinadin wants to merge 1 commit intocjpais:mainfrom
Conversation
Owner
|
Right now new features are not being accepted. You can read the stipulations for this if you really want this feature. They were there when you submitted the pull request and you did not address them. |
Author
|
Sorry about that! I really like the app and actually built this locally for my own setup first. I completely missed the feature freeze note until after I opened the PR, but I figured I'd share it in case it could be useful to others too. I'll keep using my local build for now, but let me know when you're accepting new features again and want to revisit it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Submitting This PR
Please confirm you have done the following:
If this is a feature or change that was previously closed/rejected:
Human Written Description
I added MIDI input support as an additional way to trigger transcription, without replacing or changing the existing keyboard shortcut behavior. I wanted this for convenience in my own workflow (MIDI pedal trigger while keyboard shortcuts are already used elsewhere), and implemented it to match existing settings patterns.
Testing
bun run format:checkbun run lintbun run buildbun run check:translationscargo checkcargo clippy(remaining warnings are pre-existing in unrelated files)bun run tauri devI only tested on macOS (Mac mini M4 Pro / Silicon). I tried the MIDI flow with 3 different MIDI devices (selection, binding, reset, trigger behavior)
AI Assistance
No AI was used in this PR
AI was used (please describe below)
Tools used: OpenCode (gpt-5.3-codex)
How extensively: Implementation/refactoring support across Rust and React, i18n, command/event wiring, validation runs, and iterative bug fixing.