Improved calculating pre-release versions that start with the same base name

[psmyrek]

Suggested merge commit message (convention)

Other (release-tools): Exported the getDateIdentifier() util that converts the current date into YYYYMMDD format.

Other (release-tools): Improved the getLastPreRelease() util to distinguish pre-release versions starting with the same base name. Previously, getLastPreRelease( '0.0.0-nightly' ) matched both 0.0.0-nightly and 0.0.0-nightly-next versions, but now only the first one is matched.

---

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

[coveralls]

coverage: 87.984% (+0.009%) from 87.975%
when pulling dc597e1 on cc/7040
into b70aa02 on master.

[filipsobol]

Suggested change

	const optionalSequenceNumber = '(.[0-9]+)?';
	const optionalSequenceNumber = '(\.[0-9]+)?';

Match literal .

[filipsobol]

Just a random idea, but maybe we should separate all bits that are important to us by . instead of a mix of . and -?

Given this example:

0.0.0-nightly-next-20230615.0
                  ^        ^

This version number consists of:

MAJOR.MINOR.PATCH-channel_and_date.version

However, according to spec, each identifier in the pre-release portion (after first -) should be dot-separated, so the correct version should be:

0.0.0-nightly-next.20230615.0
                  ^ `.` instead of `-`

This version number consists of:

MAJOR.MINOR.PATCH-channel.date.version

With this approach, we could use semver (which we already have) to parse version numbers instead of using Regexp.

import semver from 'semver';

const data = semver.parse( '0.0.0-nightly-next.20230615.0' );

/**
 * data.raw = '0.0.0-nightly-next.20230615'
 * data.major = 0
 * data.minor = 0
 * data.patch = 0
 * data.prerelease = [ 'nightly-next', '20230615', 0 ]
 */

If this is the only place we do it, then it shouldn't be an issue, but if we have more such places, then relying on official npm tooling would be nice.

[psmyrek]

Yeah, due to the fact we are separating nightly-YYYYMMDD with - instead of ., we can't use semver.prerelease() to parse the version, so currently we are doing it manually with regexp.

So question is do we accept to change the versioning for all nightly releases:

• 0.0.0-nightly-YYYYMMDD.X -> 0.0.0-nightly.YYYYMMDD.X
• 0.0.0-nightly-next-YYYYMMDD.X -> 0.0.0-nightly.next.YYYYMMDD.X

[pomek]

I am fine with it, but I wonder if it's a breaking change. Or, whether it should be marked as.