fix: lock adm-zip to version 0.5.12

0.5.13+ is broken, extract empty on Windows - cthackers/adm-zip#538 - fannheyward/coc-rust-analyzer#1281
clangd · Feb 21, 2025 · 1d892ba · 1d892ba
1 parent e801a88
commit 1d892ba
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -26,7 +26,7 @@
     "url": "https://github.com/clangd/node-clangd/issues"
   },
   "dependencies": {
-    "adm-zip": "^0.5.14",
+    "adm-zip": "0.5.12",
     "node-fetch": "^2.7.0",
     "readdirp": "^4.1.1",
     "rimraf": "^6.0.1",

diff --git a/src/index.ts b/src/index.ts
@@ -323,8 +323,9 @@ namespace Install {
     }
     await ui.slow(
       ui.localize('Extracting {0}', asset.name),
-      new Promise((resolve) => {
-        zip.extractAllToAsync(extractRoot, true, false, resolve);
+      new Promise<void>((resolve) => {
+        zip.extractAllTo(extractRoot, true, false);
+        resolve();
       }),
     );
     const clangdPath = path.join(extractRoot, executable.entryName);