feat(rmf): Collect from Azure in evidence tab - #1
Merged
Conversation
clarked-msft
commented
Jul 31, 2026
clarked-msft
commented
Owner
- Add start_rmf_collect / get_rmf_collect_job to functions_rmf.py
- Add POST /api/rmf/workspace/evidence/collect and GET .../collect/jobs/<job_id> routes to route_backend_rmf.py
- Add rmf-collect.js: form wiring, job polling, live log, evidence refresh
- Add Collect from Azure card to evidence tab in rmf_workspace.html (subscription ID, resource group, agentic toggle, status badge + log)
- Add start_rmf_collect / get_rmf_collect_job to functions_rmf.py - Add POST /api/rmf/workspace/evidence/collect and GET .../collect/jobs/<job_id> routes to route_backend_rmf.py - Add rmf-collect.js: form wiring, job polling, live log, evidence refresh - Add Collect from Azure card to evidence tab in rmf_workspace.html (subscription ID, resource group, agentic toggle, status badge + log) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3402ff43-7857-401e-99f5-9a34dd704d0e
The GET /api/rmf/workspace/evidence/collect/jobs/<job_id> handler was calling _rmf_group_context(user_id) with one argument — the function requires two (user_id, allowed_roles). This raised a TypeError, which Flask returned as an HTML 500 page. The JS poll then failed with 'Unexpected token < ... is not valid JSON'. Fix: pass allowed_roles=RMF_EVIDENCE_MANAGER_ROLES (matching the POST route). Also harden the JS poll to check r.ok before r.json() so any future HTTP errors surface a readable status code instead of a parse error. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The evidence tab change accidentally dropped id="rmf-analysis" from the analysis section. Bootstrap uses that id as the tab target, so the analysis pane no longer activated even though the backend endpoints were healthy. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3402ff43-7857-401e-99f5-9a34dd704d0e
The static az-CLI path is gone; collect is always agentic. Drop the toggle from the UI and hardcode agentic:true in the POST body. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3402ff43-7857-401e-99f5-9a34dd704d0e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.