Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added latex equations to latex generation, removed from pdf generation #799

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

ngersich
Copy link
Contributor

Connected to issue #727.

  • This takes advantage of the DOM parsing to add Latex to Tex files. The raw LaTeX equations are pulled out from the MathML to be included in the TeX file.
  • In the case of PDFs, this simply removes the mathML altogether. I created a long writeup in Verify MathML production for equations #727 of the different things I've tried throughout the semester to try to correct the issue. While often close, I was never able to get all the features working that are necessary for INotes (most notably images). I'm not sure if this is something that should be prioritized or is worth the effort to fix.

@ngersich ngersich requested a review from angrave April 27, 2024 00:14
@angrave angrave merged commit d6ae442 into staging Apr 29, 2024
2 checks passed
@angrave angrave deleted the inote-latex branch June 8, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants