Skip to content

Add devcontainer + Copilot instructions - #7

Merged
gn00295120 merged 2 commits into
mainfrom
add-dev-config
Mar 24, 2026
Merged

Add devcontainer + Copilot instructions#7
gn00295120 merged 2 commits into
mainfrom
add-dev-config

Conversation

@gn00295120

Copy link
Copy Markdown
Contributor
  • devcontainer.json — one-click Codespaces setup
  • .github/copilot-instructions.md — project-specific Copilot context

Copilot AI review requested due to automatic review settings March 24, 2026 14:05
@gn00295120
gn00295120 merged commit 72716f8 into main Mar 24, 2026
@gn00295120
gn00295120 deleted the add-dev-config branch March 24, 2026 14:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds developer-experience scaffolding for this repository (Codespaces/devcontainer setup plus Copilot context) to make onboarding and local development more consistent with the project’s Python + MCP server workflow.

Changes:

  • Add .devcontainer/devcontainer.json for a one-click containerized Python dev environment.
  • Add .github/copilot-instructions.md to provide project-specific Copilot guidance (NotebookLM + Claude + MCP tools, testing/style expectations).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/copilot-instructions.md Adds Copilot context about the project and expected coding/testing practices.
.devcontainer/devcontainer.json Defines a devcontainer image, post-create dependency installation, and recommended VS Code extensions.

@@ -0,0 +1 @@
This is a Python project that integrates Google NotebookLM with Claude for content generation. It provides 13 MCP tools. Follow PEP 8, use type hints, and write pytest-compatible tests.

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Copilot instructions say to “Follow PEP 8”, but the repo’s enforced style is Ruff with line-length = 120 and E501 ignored (so it does not strictly follow PEP 8 line-length rules). To avoid misleading guidance, consider updating this to reference the actual Ruff configuration (and/or the 120-char line length) rather than generic PEP 8.

Suggested change
This is a Python project that integrates Google NotebookLM with Claude for content generation. It provides 13 MCP tools. Follow PEP 8, use type hints, and write pytest-compatible tests.
This is a Python project that integrates Google NotebookLM with Claude for content generation. It provides 13 MCP tools. Follow the Ruff configuration (120-character line length; generally PEP 8-aligned with E501 disabled), use type hints, and write pytest-compatible tests.

Copilot uses AI. Check for mistakes.
Comment on lines +4 to +6
"postCreateCommand": "pip install -e \".[dev]\" 2>/dev/null || pip install -r requirements.txt 2>/dev/null || true",
"customizations": {
"vscode": {

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postCreateCommand suppresses errors (2>/dev/null) and then unconditionally succeeds (|| true). This can leave a Codespace/devcontainer in a broken state with missing dependencies (and the fallback pip install -r requirements.txt also skips dev deps like pytest/ruff). Consider removing the stderr suppression and the final || true so failures are visible, and (if you want the container to be usable for auth flows) optionally add a step to install Playwright browsers (e.g., Chromium) as documented in the repo setup guide.

Suggested change
"postCreateCommand": "pip install -e \".[dev]\" 2>/dev/null || pip install -r requirements.txt 2>/dev/null || true",
"customizations": {
"vscode": {
"postCreateCommand": "pip install -e \".[dev]\" || pip install -r requirements.txt",
"customizations": {
"vscode": {

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants