test(server): cover reassign-to-self visible writes and run-lock deny copy on issue mutation routes - #332
Open
claudegoogl-sudo wants to merge 1 commit into
Open
Conversation
… copy Add four regression tests to issue-agent-mutation-ownership-routes: - AC1: the creating agent can retract an idle agent-assigned issue by reassigning to itself and cancelling (default-open visible write) - AC2: the same creator patch is denied with the run-lock deny copy while the assignee holds the checkout - AC3: an unrelated standard-trust agent can reassign the idle agent-assigned issue to itself - AC4: an out-of-visibility actor is still denied with the not-visible code on both read and write Includes the read-projection mocks the tests need. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
Linked Issues or Issue Description
Refs: #323 — locks in the reassign-to-self and run-lock deny behavior around the ownership guards this PR landed.
What Changed
creator reassign-to-self on idle agent-assigned issues (default-open visible write)toserver/src/__tests__/issue-agent-mutation-ownership-routes.test.tswith four regression tests:Verification
cd server && npx vitest run src/__tests__/issue-agent-mutation-ownership-routes.test.ts→Test Files 1 passed (1),Tests 91 passed (91)(about 50 s), including all four new tests.pnpm test:run). This PR touches one test file and adds no production code. CI on this PR runs the wider gates.Risks
Model Used
GLM (
glm-5-turbo) via the Z.ai provider, running as an autonomous coding agent (tool use, code execution, extended reasoning). The change was authored and verified by this agent with no human editing.Checklist
reassign,mutation ownership,issue-agent-mutation-ownership-routes; no duplicates found, related: fix(server): let contextless heartbeat runs write issues under the run cap #323)Fixes: #/Closes #/Refs #OR (b) described the issue in-PR following the relevant issue template (Refs: fix(server): let contextless heartbeat runs write issues under the run cap #323)#NNN/github.com/paperclipai/paperclipURLs)docs/...,fix/...) and contains no internal Paperclip ticket id or instance-derived details (test/issue-visible-write-reassign-regression)Follows
CONTRIBUTING.mdPR template — sections present: Thinking Path, Linked Issues or Issue Description, What Changed, Verification, Risks, Model Used, Checklist (all headings verbatim from.github/PULL_REQUEST_TEMPLATE.mdat HEAD).