Add support for line break in the body parameter.#1
Merged
Conversation
"\n" in the body does not work if coercion type of a mail is HTML. We should convert it to HTML.
Member
|
この実装だと本文テンプレートに文字装飾のタグなどは書けないということになりそうですが、そのように制約を加えても大丈夫でしょうか? |
Contributor
Author
|
現状は本文テンプレートはHTMLを使わない想定でいます。 ユーザーがHTMLを書くことをサポートする場合、HTMLBodyというような別のプロパティを設定ファイルに追加して、作成しようとしているメールの本文の形式がプレーンテキスト形式ならBodyプロパティ、HTML形式ならHTMLBodyプロパティを使うというような分岐にするのが良いのではないかと思いました。(現在のBodyプロパティの内容をHTML形式に変換する機能はドロップする) |
Member
|
了解です、その設計であれば問題ないと思います! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"\n" in the body does not work if coercion type of a mail is HTML. We should convert it to HTML.
Test