add reusable workflow for dev deploy #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrayle
force-pushed
the
elr/shared-dev-deploy
branch
from
fb0b3f1 to
bacaa08
Compare
elrayle
force-pushed
the
elr/shared-dev-deploy
branch
from
afa194d to
f69aaa7
Compare
elrayle
changed the title
Configs have to go before deploy because they are used in the restart after the deploy. QUESTION: If the deploy fails, do the configs automatically get reverted?
jmeridth
approved these changes
Apr 11, 2024
|
This is superseded by the work in: The new PRs combine the dev and deploy workflows into a single shared workflow in operations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move dev deploy workflow from service to operations and generalize it for use with all primary apps (i.e. service, crawler, website)
Related Work
Summary of fixes:
Multiple issues were in the original workflow:
To avoid these known issues, the PR updates the workflow copied from clearlydefined/service to...
NOTE: Configs cannot be moved after the deploy because they are used by the restart process kicked of by the deploy.
Follow-on Work