Skip to content

Add handshake animation to HCW #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025
Merged

Add handshake animation to HCW #2191

merged 4 commits into from
Apr 28, 2025

Conversation

jescalan
Copy link
Contributor

@jescalan jescalan commented Apr 19, 2025

🔎 Previews:

What does this solve?

Handshake is a challenging architectural concept and I felt like adding an animation to clarify the flow might help readers to better contextualize how it works. Big props to the design team for nailing the graphics here on the first shot!

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • All existing checks pass

@jescalan jescalan requested a review from a team as a code owner April 19, 2025 18:34
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/2191

@alexisintech
Copy link
Member

Screenshot 2025-04-21 at 12 43 20

"User requests app from server" I'm not really sure what this is trying to say - Maybe "User makes a request to the server with an expired token"? Also "w/expired token" should be "with expired token" as not everyone, especially non-english native speakers, will know what "w/" stands for.



Screenshot 2025-04-21 at 12 48 22

Should be "Server returns a redirect response to the browser. This includes a callback URL to the server."

Screenshot 2025-04-21 at 12 49 50

Should be "FAPI checks the authentication state and if valid, returns a new session token when it returns the request to the server callback URL." we can say returns a new session token or mints a new session token or whatever jargon sounds better here, but we should make it clear that FAPI checks the client cookie to check the auth state. if it's valid, it will return a new session token, but if it's not valid, it won't.

@jescalan
Copy link
Contributor Author

Getting the suggested copy changes addressed by design ⏲️

@jescalan
Copy link
Contributor Author

Ok @alexisintech updated video with text edits

Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup!! love it 💘

@alexisintech alexisintech merged commit 8a7efa8 into main Apr 28, 2025
8 checks passed
@alexisintech alexisintech deleted the je.add-handshake-video branch April 28, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants