Chris/mobile 279 expo sign in with apple #2732
Conversation
…ce clarity on testing and configuration steps
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Fix for vercel builds.
…eSignIn()` documentation
|
Overall this looks great @chriscanin! I left just a few comments and I'll leave the technical review to the js team and the content review to the docs team 😃 Nice first docs PR! 🚀 |
Hey @mikepitre , did not see any comments here on this repo. Maybe they were not published if it was a review? Let me know! |
|
|
||
| ### Prerequisites | ||
|
|
||
| Before using this hook, ensure you have: |
There was a problem hiding this comment.
Do you need to mention adding to the native applications page here?
you are correct, I never hit submit. They should be there now 🙈 |
|
@chriscanin @mikepitre @alexisintech - have just submitted a docs review. Have a look, and let me know thoughts. I will also leave some comments about certain things I'm hesitating about before I can approve, and want Alexis to have a second look as well. This is a great addition Chris, thank you 🚀 |
| > [!NOTE] | ||
| > Apple Sign-In works on both iOS Simulators and physical devices. However, physical devices provide full functionality including biometric authentication (Face ID/Touch ID), while simulators have limited support. Always test on a physical device before releasing to production. |
There was a problem hiding this comment.
Moved this at the top, as it used to be part of the last step, but I thought it looked out of place. Happy to hear other perspectives tho.
There was a problem hiding this comment.
Also, is this callout needed in the original Sign in with Apple guide for iOS?
|
|
||
| ## Create a native build | ||
|
|
||
| Create a native build with EAS Build or a local prebuild, since Apple Authentication is not supported in Expo Go. |
There was a problem hiding this comment.
This is info that was duplicated as a callout at the start of the guide, and felt it made more sense here, and instead move up the other callout around physical devices. Again, happy to hear other perspectives.
|
|
||
| The `useAppleSignIn()` hook provides native Sign in with Apple functionality for iOS devices. It automatically handles the ID token exchange with Clerk's Backend and manages the transfer flow between sign-in and sign-up. | ||
|
|
||
| ### Prerequisites |
There was a problem hiding this comment.
I'm unsure about this section. While I think it is useful, maybe, it'll be more straightforward and cleaner to have this in a <TutorialHero />, and just link to the Sign in with Apple for Expo guide. Keen to hear your thoughts on this @alexisintech!
| ## Error handling | ||
|
|
||
| The `useAppleSignIn()` hook may throw errors in the following scenarios: | ||
|
|
||
| - **User cancellation**: The user cancels the sign-in flow, resulting in an error with code `ERR_REQUEST_CANCELED`. |
There was a problem hiding this comment.
Do we perhaps want this in the guide itself as well?
| sdk: expo | ||
| --- | ||
|
|
||
| This guide will teach you how to add native Sign in with Apple to your Clerk Expo apps. |
There was a problem hiding this comment.
| This guide will teach you how to add native Sign in with Apple to your Clerk Expo apps. | |
| This guide will teach you how to add native [Sign in with Apple](https://support.apple.com/en-us/102609) to your Clerk Expo apps. |
| > [!NOTE] | ||
| > This hook is only available on iOS devices and requires a native build. It will not work with Expo Go. | ||
|
|
||
| The `useAppleSignIn()` hook provides native Sign in with Apple functionality for iOS devices. It automatically handles the ID token exchange with Clerk's Backend and manages the transfer flow between sign-in and sign-up. |
There was a problem hiding this comment.
| The `useAppleSignIn()` hook provides native Sign in with Apple functionality for iOS devices. It automatically handles the ID token exchange with Clerk's Backend and manages the transfer flow between sign-in and sign-up. | |
| The `useAppleSignIn()` hook provides native [Sign in with Apple](https://support.apple.com/en-us/102609) functionality for iOS devices. It automatically handles the ID token exchange with Clerk's Backend and manages the transfer flow between sign-in and sign-up. |
…ion and examples
5 participants
🔎 Previews:
https://clerk.com/docs/pr/chris-mobile-279-expo-sign-in-with-apple/expo/getting-started/quickstart
https://clerk.com/docs/pr/chris-mobile-279-expo-sign-in-with-apple/expo/guides/configure/auth-strategies/sign-in-with-apple
https://clerk.com/docs/pr/chris-mobile-279-expo-sign-in-with-apple/reference/expo/use-apple-sign-in
What does this solve?
This documentation helps to better explain the process of adding a native apple sign in / sign up button to your expo application in iOS.
What changed?
I have added a created an apple sign in installation guide, and added a hook details page. I have also added these items to the side menu as they are placed in the iOS section, so that the expo documentation matches as closely as possible.
Checklist