-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chrome-extension): Handle manifest permissions in a more-deterministic fashion #4133
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 73c16ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0d7e15a
to
3ed7014
Compare
3ed7014
to
de23c83
Compare
0a26a9c
to
36fa5a4
Compare
555e2e5
to
5290072
Compare
!allow-major |
@@ -35,71 +35,14 @@ describe('Cookies', () => { | |||
} | |||
|
|||
describe('getClientCookie', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduced complexity of the getClientCookie
thus these tests are no longer necessary.
host_permissions: ['http://localhost:3000'], | ||
} as ValidatedManifest; | ||
import { missingManifestKeyError } from '../errors'; | ||
import { validateManifest } from '../manifest'; | ||
|
||
describe('Manifest', () => { | ||
describe('validateManifest(manifest)', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduced complexity of the validateManifest
thus these tests are no longer necessary.
d660bde
to
163bb22
Compare
|
||
#### Extension Manifest (`manifest.json`) | ||
### Usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split docs out into separate files as we've found that important details tended to be missed/buried otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been working with this for the last week testing and building apps for documentation and so far there have been no issues. Excited to see this release! 🚀
163bb22
to
6940054
Compare
a0079e1
to
5846131
Compare
!snapshot |
Hey @tmilewski - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact |
5846131
to
73c16ec
Compare
Description
Breaking Change: Service Workers / Session Handling
The extension now requires the
storage
permission in order to maintain sessions and provide authenticated access to other extension features, such as service workers.How to Update:
storage
to thepermissions
key in your extension manifest.Breaking Change: Host Session Syncing
The extension no longer infers the sync host as the original implementation led to increased configuration confusion and false positives.
As such, we've replaced
syncSessionWithTab
withsyncHost
. You can setsyncHost
to the host URL you intend to retrieve the authentication state from.How to Update:
syncSessionWithTab
withsyncHost="<YOUR_CLERK_FRONTEND_API_DOMAIN>"
host_permissions
and appended with/*
. e.g.:https://<YOUR_DOMAIN>/*
andhttps://clerk.<YOUR_DOMAIN>/*
Fixes ECO-212
Feature: Service Workers
createClerkClient
We've introduced a new method
createClerkClient
to handle background tasks in your extension!Fixes ECO-213
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change