Skip to content

feat(clerk-js): Add colorShadow variable option #6290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 14, 2025
Merged

feat(clerk-js): Add colorShadow variable option #6290

merged 6 commits into from
Jul 14, 2025
+69 −20

Conversation

alexcarpenter
Copy link
Member

Description

This PR adds support for colorShadow variable usage. We've simplified the shadows to be derived from a single value instead of the custom rgb values.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1f3a088

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jul 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 3:18pm

panteliselef
panteliselef approved these changes Jul 13, 2025
View reviewed changes
packages/types/src/appearance.ts
@@ -731,8 +731,8 @@ export type Variables = {
*/
colorRing?: CssColor;
/**
* The color of the shadow used in card components.
* @default 'rgba(25, 28, 33, 0.20)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this the case for only shadows.input and shadows.focusRing ? Or for none at all ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand the question.

@alexcarpenter
Merge branch 'alexcarpenter/user-2202-add-clerk-css-variable-utilitie…
1f3a088 
…s-for-current-variables' into alexcarpenter/variables-color-shadow
@alexcarpenter alexcarpenter merged commit aa65eec into alexcarpenter/user-2202-add-clerk-css-variable-utilities-for-current-variables Jul 14, 2025
7 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/variables-color-shadow branch July 14, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikosdouvlis nikosdouvlis nikosdouvlis approved these changes

@panteliselef panteliselef panteliselef approved these changes

Assignees
No one assigned
Labels
clerk-js types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexcarpenter @nikosdouvlis @panteliselef @clerk-cookie