-
Notifications
You must be signed in to change notification settings - Fork 376
Updated translations for IN languages and MY language #6553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
translation for Hindi, Bengali, Tamil, Telugu and Malay added
update translations for MY and IN languages to be in sync with en
|
@vanikya is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughAdds and expands localization content across five locale files: bn-IN, hi-IN, ms-MY, ta-IN, and te-IN. Introduces a new top-level taskChooseOrganization group in each affected locale with nested signOut, createOrganization, and chooseOrganization keys. Substantially populates previously undefined strings across API keys, billing/commerce/checkout, subscriptions/plans, organization/profile pages, navbar, sign-in/up/MFA flows, footer, and error messages. Many placeholders and date/amount interpolations are added per locale conventions. Public exports change accordingly with numerous new keys and translated values. No program logic changes. Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 12
🧹 Nitpick comments (1)
packages/localizations/src/te-IN.ts (1)
72-86
: Nit: standardize interpolation spacing for readabilitySome entries use
{{date}}
without spaces while others use{{ date }}
. Consider standardizing for consistency and readability.If desired, I can send a codemod to normalize this across all locales.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
packages/localizations/src/bn-IN.ts
(20 hunks)packages/localizations/src/hi-IN.ts
(20 hunks)packages/localizations/src/ms-MY.ts
(22 hunks)packages/localizations/src/ta-IN.ts
(22 hunks)packages/localizations/src/te-IN.ts
(22 hunks)
🧰 Additional context used
📓 Path-based instructions (9)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
**/*.{js,jsx,ts,tsx}
: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels
Files:
packages/localizations/src/te-IN.ts
packages/localizations/src/hi-IN.ts
packages/localizations/src/ta-IN.ts
packages/localizations/src/bn-IN.ts
packages/localizations/src/ms-MY.ts
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/localizations/src/te-IN.ts
packages/localizations/src/hi-IN.ts
packages/localizations/src/ta-IN.ts
packages/localizations/src/bn-IN.ts
packages/localizations/src/ms-MY.ts
packages/**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
packages/localizations/src/te-IN.ts
packages/localizations/src/hi-IN.ts
packages/localizations/src/ta-IN.ts
packages/localizations/src/bn-IN.ts
packages/localizations/src/ms-MY.ts
packages/**/*.{ts,tsx,d.ts}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Packages should export TypeScript types alongside runtime code
Files:
packages/localizations/src/te-IN.ts
packages/localizations/src/hi-IN.ts
packages/localizations/src/ta-IN.ts
packages/localizations/src/bn-IN.ts
packages/localizations/src/ms-MY.ts
**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
**/*.{ts,tsx}
: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoidany
type - preferunknown
when type is uncertain, then narrow with type guards
Useinterface
for object shapes that might be extended
Usetype
for unions, primitives, and computed types
Preferreadonly
properties for immutable data structures
Useprivate
for internal implementation details
Useprotected
for inheritance hierarchies
Usepublic
explicitly for clarity in public APIs
Preferreadonly
for properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Useconst assertions
for literal types:as const
Usesatisfies
operator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports:import type { ... } from ...
Noany
types without justification
Proper error handling with typed errors
Consistent use ofreadonly
for immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)
Files:
packages/localizations/src/te-IN.ts
packages/localizations/src/hi-IN.ts
packages/localizations/src/ta-IN.ts
packages/localizations/src/bn-IN.ts
packages/localizations/src/ms-MY.ts
packages/localizations/**/*
📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)
Localization files must be placed in 'packages/localizations/'.
Files:
packages/localizations/src/te-IN.ts
packages/localizations/src/hi-IN.ts
packages/localizations/src/ta-IN.ts
packages/localizations/src/bn-IN.ts
packages/localizations/src/ms-MY.ts
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)
Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.
Files:
packages/localizations/src/te-IN.ts
packages/localizations/src/hi-IN.ts
packages/localizations/src/ta-IN.ts
packages/localizations/src/bn-IN.ts
packages/localizations/src/ms-MY.ts
**/*
⚙️ CodeRabbit Configuration File
If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.
Files:
packages/localizations/src/te-IN.ts
packages/localizations/src/hi-IN.ts
packages/localizations/src/ta-IN.ts
packages/localizations/src/bn-IN.ts
packages/localizations/src/ms-MY.ts
**/localizations/**/*.ts
⚙️ CodeRabbit Configuration File
**/localizations/**/*.ts
: Review the changes to localization files with the following guidelines:
- Ensure that no existing translations are accidentally removed unless they are being replaced or fixed. If a string is removed, verify that it is intentional and justified.
- Check that all translations are friendly, formal, or semi-formal. Explicit, offensive, or inappropriate language is not allowed. If you find any potentially offensive language or are unsure, tag the @clerk/sdk-infra team in a separate comment. If you do not intend to tag the team, refer to it as "Clerk SDK Infra team" instead.
- Use the most up-to-date base localization file (https://github.com/clerk/javascript/blob/main/packages/localizations/src/en-US.ts) to validate changes, ensuring consistency and completeness.
- Confirm that new translations are accurate, contextually appropriate, and match the intent of the original English strings.
- Check for formatting issues, such as missing placeholders, incorrect variable usage, or syntax errors.
- Ensure that all keys are unique and that there are no duplicate or conflicting entries.
- If you notice missing translations for new keys, flag them for completion.
Files:
packages/localizations/src/te-IN.ts
packages/localizations/src/hi-IN.ts
packages/localizations/src/ta-IN.ts
packages/localizations/src/bn-IN.ts
packages/localizations/src/ms-MY.ts
🪛 Biome (2.1.2)
packages/localizations/src/te-IN.ts
[error] 17-45: This property is later overwritten by an object member with the same name.
Overwritten with this property.
If an object property with the same name is defined multiple times (except when combining a getter with a setter), only the last definition makes it into the object and previous definitions are ignored.
Unsafe fix: Remove this property.
(lint/suspicious/noDuplicateObjectKeys)
packages/localizations/src/hi-IN.ts
[error] 17-43: This property is later overwritten by an object member with the same name.
Overwritten with this property.
If an object property with the same name is defined multiple times (except when combining a getter with a setter), only the last definition makes it into the object and previous definitions are ignored.
Unsafe fix: Remove this property.
(lint/suspicious/noDuplicateObjectKeys)
packages/localizations/src/ta-IN.ts
[error] 17-45: This property is later overwritten by an object member with the same name.
Overwritten with this property.
If an object property with the same name is defined multiple times (except when combining a getter with a setter), only the last definition makes it into the object and previous definitions are ignored.
Unsafe fix: Remove this property.
(lint/suspicious/noDuplicateObjectKeys)
packages/localizations/src/bn-IN.ts
[error] 17-45: This property is later overwritten by an object member with the same name.
Overwritten with this property.
If an object property with the same name is defined multiple times (except when combining a getter with a setter), only the last definition makes it into the object and previous definitions are ignored.
Unsafe fix: Remove this property.
(lint/suspicious/noDuplicateObjectKeys)
packages/localizations/src/ms-MY.ts
[error] 17-36: This property is later overwritten by an object member with the same name.
Overwritten with this property.
If an object property with the same name is defined multiple times (except when combining a getter with a setter), only the last definition makes it into the object and previous definitions are ignored.
Unsafe fix: Remove this property.
(lint/suspicious/noDuplicateObjectKeys)
🔇 Additional comments (2)
packages/localizations/src/bn-IN.ts (1)
208-208
: Verify intended meaning for “Alternative phone code provider”
footerActionLink__alternativePhoneCodeProvider
is translated as “পরিবর্তে এসএমএসের মাধ্যমে কোড পাঠান” (send code via SMS instead), which changes the meaning from “Alternative phone code provider”.Consider a closer rendering like “বিকল্প ফোন কোড প্রদানকারী”.
Would you like me to propose a consistent set of strings for the alternative provider feature across locales?
packages/localizations/src/ta-IN.ts (1)
208-208
: Potential mistranslation: “Alternative phone code provider”
footerActionLink__alternativePhoneCodeProvider
is translated as “பதிலாக SMS மூலம் குறியீடு அனுப்பவும்” (send code via SMS instead), which changes the meaning from “Alternative phone code provider”.Suggest something closer to the source, e.g., “மாற்று தொலைபேசி குறியீடு வழங்குநர்”.
I can propose a consistent set across locales if you confirm the intended UX for this feature.
taskChooseOrganization: { | ||
signOut: { | ||
actionLink: 'সাইন আউট', | ||
actionText: '{{identifier}} হিসাবে সাইন ইন করা হয়েছে', | ||
}, | ||
createOrganization: { | ||
title: 'আপনার অ্যাকাউন্ট সেটআপ করুন', | ||
subtitle: 'আপনার সংগঠন সম্পর্কে আমাদের একটু বলুন', | ||
formButtonSubmit: 'নতুন সংগঠন তৈরি করুন', | ||
formButtonReset: 'বাতিল করুন', | ||
}, | ||
chooseOrganization: { | ||
title: 'একটি সংগঠন চয়ন করুন', | ||
subtitle: 'একটি বিদ্যমান সংগঠনে যোগ দিন বা একটি নতুন তৈরি করুন', | ||
suggestionsAcceptedLabel: 'অনুমোদনের অপেক্ষায়', | ||
action__createOrganization: 'নতুন সংগঠন তৈরি করুন', | ||
action__suggestionsAccept: 'যোগ দেওয়ার অনুরোধ করুন', | ||
action__invitationAccept: 'যোগ দিন', | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate key: taskChooseOrganization is overwritten, dropping your new translations
taskChooseOrganization
is declared twice. The later block (Lines 829–847) replaces the earlier translated block (Lines 17–36) with undefined
values. This matches Biome’s duplicate object keys error and will break the locale.
Remove the later duplicate.
Apply this diff:
- taskChooseOrganization: {
- chooseOrganization: {
- action__createOrganization: undefined,
- action__invitationAccept: undefined,
- action__suggestionsAccept: undefined,
- subtitle: undefined,
- suggestionsAcceptedLabel: undefined,
- title: undefined,
- },
- createOrganization: {
- formButtonReset: undefined,
- formButtonSubmit: undefined,
- subtitle: undefined,
- title: undefined,
- },
- signOut: {
- actionLink: undefined,
- actionText: undefined,
- },
- },
Also applies to: 829-847
🧰 Tools
🪛 Biome (2.1.2)
[error] 17-45: This property is later overwritten by an object member with the same name.
Overwritten with this property.
If an object property with the same name is defined multiple times (except when combining a getter with a setter), only the last definition makes it into the object and previous definitions are ignored.
Unsafe fix: Remove this property.
(lint/suspicious/noDuplicateObjectKeys)
🤖 Prompt for AI Agents
In packages/localizations/src/bn-IN.ts around lines 17 to 36 (and duplicate at
829 to 847), the object key taskChooseOrganization is declared twice causing the
later block to overwrite the earlier translations and trigger Biome’s duplicate
key error; remove the duplicate block at lines 829–847 (or merge any missing
keys from that block into the canonical one at 17–36) so only a single
taskChooseOrganization declaration remains, then run the linter/formatting to
ensure no duplicate-key errors remain.
badge__freeTrial: undefined, | ||
badge__otherImpersonatorDevice: 'অন্য ইমপারসোনেটর ডিভাইস', | ||
badge__pastDueAt: undefined, | ||
badge__pastDuePlan: undefined, | ||
badge__pastDueAt: "মেয়াদ উত্তীর্ণ {{ date | shortDate('bn-IN') }}", | ||
badge__pastDuePlan: 'মেয়াদ উত্তীর্ণ', | ||
badge__primary: 'প্রাথমিক', | ||
badge__renewsAt: undefined, | ||
badge__renewsAt: "নবায়ন {{ date | shortDate('bn-IN') }}", | ||
badge__requiresAction: 'কর্ম প্রয়োজন', | ||
badge__startsAt: undefined, | ||
badge__startsAt: "শুরু {{ date | shortDate('bn-IN') }}", | ||
badge__thisDevice: 'এই ডিভাইস', | ||
badge__trialEndsAt: undefined, | ||
badge__unverified: 'অযাচাই', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Fill missing translations left as undefined
Some keys under badges and checkout line items are undefined
. If there’s no runtime fallback, these labels will be blank.
List them with:
Also applies to: 118-125, 162-168
🏁 Script executed:
#!/bin/bash
rg -nP ":\s*undefined\b" packages/localizations/src/bn-IN.ts
Length of output: 887
Fill missing bn-IN translations (undefined entries found)
Several keys in packages/localizations/src/bn-IN.ts are set to undefined
. If there’s no runtime fallback, these labels will render blank — please add Bengali translations or confirm fallbacks.
Locations (file:line — key)
- packages/localizations/src/bn-IN.ts:78 — badge__freeTrial
- packages/localizations/src/bn-IN.ts:87 — badge__trialEndsAt
- packages/localizations/src/bn-IN.ts:118 — title__freeTrialEndsAt
- packages/localizations/src/bn-IN.ts:123 — title__trialSuccess
- packages/localizations/src/bn-IN.ts:124 — totalDueAfterTrial
- packages/localizations/src/bn-IN.ts:166 — startFreeTrial
- packages/localizations/src/bn-IN.ts:167 — startFreeTrial__days
- packages/localizations/src/bn-IN.ts:237 — formFieldInputPlaceholder__username
- packages/localizations/src/bn-IN.ts:728 — subtitleCombined
- packages/localizations/src/bn-IN.ts:830 — action__createOrganization
- packages/localizations/src/bn-IN.ts:831 — action__invitationAccept
- packages/localizations/src/bn-IN.ts:832 — action__suggestionsAccept
- packages/localizations/src/bn-IN.ts:833 — subtitle
- packages/localizations/src/bn-IN.ts:834 — suggestionsAcceptedLabel
- packages/localizations/src/bn-IN.ts:835 — title
- packages/localizations/src/bn-IN.ts:838 — formButtonReset
- packages/localizations/src/bn-IN.ts:839 — formButtonSubmit
- packages/localizations/src/bn-IN.ts:840 — subtitle
- packages/localizations/src/bn-IN.ts:841 — title
- packages/localizations/src/bn-IN.ts:844 — actionLink
- packages/localizations/src/bn-IN.ts:845 — actionText
Please replace undefined
with appropriate Bengali strings (or confirm an app-level fallback).
🤖 Prompt for AI Agents
packages/localizations/src/bn-IN.ts around lines 78–88 (and the other lines
referenced in the comment: 118, 123, 124, 166–167, 237, 728, 830–835, 838–845) —
several localization keys are set to undefined; replace each undefined value
with an appropriate Bengali string; specifically set badge__freeTrial = 'ফ্রি
ট্রায়াল', badge__trialEndsAt = "ট্রায়াল শেষ হচ্ছে {{ date | shortDate('bn-IN')
}}", title__freeTrialEndsAt = "ফ্রি ট্রায়াল শেষ হবে {{ date |
shortDate('bn-IN') }}", title__trialSuccess = 'ট্রায়াল সফল হয়েছে',
totalDueAfterTrial = 'ট্রায়াল শেষে মোট_due', startFreeTrial = 'ফ্রি ট্রায়াল
শুরু করুন', startFreeTrial__days = '{{count}} দিনের ফ্রি ট্রায়াল শুরু করুন',
formFieldInputPlaceholder__username = 'ব্যবহারকারীর নাম লিখুন', subtitleCombined
= 'উপশিরোনাম মিলিত', action__createOrganization = 'সংগঠন তৈরি করুন',
action__invitationAccept = 'আমন্ত্রণ গ্রহণ করুন', action__suggestionsAccept =
'সুপারিশ গ্রহণ করুন', subtitle = 'উপশিরোনাম', suggestionsAcceptedLabel =
'সুপারিশ গৃহীত', title = 'শিরোনাম', formButtonReset = 'রিসেট', formButtonSubmit
= 'জমা দিন', subtitle = 'উপশিরোনাম', title = 'শিরোনাম', actionLink = 'ক্রিয়ার
লিংক', actionText = 'ক্রিয়া টেক্সট' — or replace with your preferred Bengali
phrasing; commit the changes so no runtime undefined translations remain.
beginsOn: 'শুরু হয়', | ||
currentBillingCycle: 'বর্তমান বিলিং চক্র', | ||
endsOn: 'শেষ হয়', | ||
nextPaymentAmount: 'পরবর্তী পেমেন্টের পরিমাণ', | ||
nextPaymentOn: 'পরবর্তী পেমেন্ট', | ||
pastDueAt: 'মেয়াদ উত্তীর্ণ', | ||
renewsAt: 'নবায়ন হয়', | ||
subscribedOn: 'সাবস্ক্রাইব করেছেন', | ||
title: 'সাবস্ক্রিপশন', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placeholders missing in subscriptionDetails (dates are not interpolated)
Keys like beginsOn
, endsOn
, nextPaymentOn
, pastDueAt
, renewsAt
, subscribedOn
lack the {{ date }}
placeholder, so the UI won’t show dates.
Add the {{ date }}
interpolation (optionally with formatting).
Suggested fix:
- beginsOn: 'শুরু হয়',
+ beginsOn: '{{ date }} শুরু হয়',
- currentBillingCycle: 'বর্তমান বিলিং চক্র',
- endsOn: 'শেষ হয়',
+ endsOn: '{{ date }} শেষ হয়',
- nextPaymentAmount: 'পরবর্তী পেমেন্টের পরিমাণ',
- nextPaymentOn: 'পরবর্তী পেমেন্ট',
+ nextPaymentOn: '{{ date }} তারিখে পরবর্তী পেমেন্ট',
- pastDueAt: 'মেয়াদ উত্তীর্ণ',
+ pastDueAt: '{{ date }} তারিখে মেয়াদ উত্তীর্ণ',
- renewsAt: 'নবায়ন হয়',
+ renewsAt: '{{ date }} তারিখে নবায়ন হয়',
- subscribedOn: 'সাবস্ক্রাইব করেছেন',
+ subscribedOn: '{{ date }} তারিখে সাবস্ক্রাইব করেছেন',
If you prefer the localized date filter, use {{ date | longDate('bn-IN') }}
consistently.
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In packages/localizations/src/bn-IN.ts around lines 170 to 179, the
subscriptionDetails keys (beginsOn, endsOn, nextPaymentOn, pastDueAt, renewsAt,
subscribedOn) are missing the {{ date }} placeholder so dates won't be rendered;
update each value to include the interpolation (e.g., "শুরু হয় {{ date }}"
etc.), or use the localized filter consistently like "{{ date |
longDate('bn-IN') }}" for formatted dates.
@@ -210,9 +235,9 @@ export const bnIN: LocalizationResource = { | |||
formFieldInputPlaceholder__password: 'আপনার পাসওয়ার্ড লিখুন', | |||
formFieldInputPlaceholder__phoneNumber: 'আপনার ফোন নম্বর লিখুন', | |||
formFieldInputPlaceholder__username: undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Missing username placeholder translation
formFieldInputPlaceholder__username
is undefined
. Provide a value to avoid empty input placeholders.
Apply:
- formFieldInputPlaceholder__username: undefined,
+ formFieldInputPlaceholder__username: 'ব্যবহারকারীর নাম',
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
formFieldInputPlaceholder__username: undefined, | |
formFieldInputPlaceholder__username: 'ব্যবহারকারীর নাম', |
🤖 Prompt for AI Agents
In packages/localizations/src/bn-IN.ts around line 237, the key
formFieldInputPlaceholder__username is set to undefined; replace undefined with
the appropriate Bengali (India) placeholder string for "username" (e.g., a
concise translated phrase such as the localized word for "Username" or "Enter
username") so that input fields render a visible placeholder; ensure the
translation follows existing style/format and is a simple string value.
taskChooseOrganization: { | ||
signOut: { | ||
actionLink: 'साइन आउट', | ||
actionText: '{{identifier}} के रूप में साइन इन किया गया', | ||
}, | ||
createOrganization: { | ||
title: 'अपना खाता सेटअप करें', | ||
subtitle: 'अपने संगठन के बारे में बताएं', | ||
formButtonSubmit: 'नया संगठन बनाएं', | ||
formButtonReset: 'रद्द करें', | ||
}, | ||
chooseOrganization: { | ||
title: 'एक संगठन चुनें', | ||
subtitle: 'मौजूदा संगठन में शामिल हों या नया बनाएं', | ||
suggestionsAcceptedLabel: 'अनुमोदन के लिए लंबित', | ||
action__createOrganization: 'नया संगठन बनाएं', | ||
action__suggestionsAccept: 'शामिल होने का अनुरोध करें', | ||
action__invitationAccept: 'शामिल हों', | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate key: taskChooseOrganization is overwritten, dropping your new translations
You define taskChooseOrganization
twice. The later block (Lines 824–843) overrides the earlier translated block (Lines 17–36) with undefined
values. This breaks the locale and is flagged by Biome.
Remove the second duplicate block to keep the translated one.
Apply this diff to delete the duplicate at the bottom:
- taskChooseOrganization: {
- chooseOrganization: {
- action__createOrganization: undefined,
- action__invitationAccept: undefined,
- action__suggestionsAccept: undefined,
- subtitle: undefined,
- suggestionsAcceptedLabel: undefined,
- title: undefined,
- },
- createOrganization: {
- formButtonReset: undefined,
- formButtonSubmit: undefined,
- subtitle: undefined,
- title: undefined,
- },
- signOut: {
- actionLink: undefined,
- actionText: undefined,
- },
- },
Also applies to: 824-843
🧰 Tools
🪛 Biome (2.1.2)
[error] 17-43: This property is later overwritten by an object member with the same name.
Overwritten with this property.
If an object property with the same name is defined multiple times (except when combining a getter with a setter), only the last definition makes it into the object and previous definitions are ignored.
Unsafe fix: Remove this property.
(lint/suspicious/noDuplicateObjectKeys)
🤖 Prompt for AI Agents
packages/localizations/src/hi-IN.ts around lines 17-36 and 824-843: there is a
duplicate key taskChooseOrganization defined earlier with proper Hindi
translations (lines 17–36) and again later (lines 824–843) which overwrites the
translations with undefined values; delete the later duplicate block (lines
824–843) entirely so the initial translated taskChooseOrganization remains and
ensure no other duplicate keys remain in the file.
badge__freeTrial: undefined, | ||
badge__otherImpersonatorDevice: 'Peranti penyamar lain', | ||
badge__pastDueAt: undefined, | ||
badge__pastDuePlan: undefined, | ||
badge__pastDueAt: 'Lampau tempoh pada {{ date }}', | ||
badge__pastDuePlan: 'Pelan lampau tempoh', | ||
badge__primary: 'Utama', | ||
badge__renewsAt: undefined, | ||
badge__renewsAt: 'Diperbaharui pada {{ date }}', | ||
badge__requiresAction: 'Memerlukan tindakan', | ||
badge__startsAt: undefined, | ||
badge__startsAt: 'Bermula pada {{ date }}', | ||
badge__thisDevice: 'Peranti ini', | ||
badge__trialEndsAt: undefined, | ||
badge__unverified: 'Belum disahkan', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Undefined labels in badges and checkout
A few keys (free trial badges and checkout line items) remain undefined
. If there’s no runtime fallback, the UI will show empty labels.
List them:
Also applies to: 114-127, 160-176
🏁 Script executed:
#!/bin/bash
rg -nP ":\s*undefined\b" packages/localizations/src/ms-MY.ts
Length of output: 790
Missing translations in packages/localizations/src/ms-MY.ts — several keys set to undefined
These entries are explicitly undefined
; without a runtime fallback the UI will render empty labels. Please provide translations or add fallbacks.
- packages/localizations/src/ms-MY.ts
- 78: badge__freeTrial
- 87: badge__trialEndsAt
- 114: title__freeTrialEndsAt
- 125: title__trialSuccess
- 126: totalDueAfterTrial
- 162: startFreeTrial
- 163: startFreeTrial__days
- 829: action__createOrganization
- 830: action__invitationAccept
- 831: action__suggestionsAccept
- 832: subtitle
- 833: suggestionsAcceptedLabel
- 834: title
- 837: formButtonReset
- 838: formButtonSubmit
- 839: subtitle
- 840: title
- 843: actionLink
- 844: actionText
🤖 Prompt for AI Agents
In packages/localizations/src/ms-MY.ts around lines 78 to 88 (and additionally
keys at lines 114, 125-126, 162-163, 829-844), several localization keys are set
to undefined; replace each undefined value with the correct Malay translation
strings or wire them to a safe fallback (e.g., import the default/en locale and
assign fallback values like en.title__freeTrialEndsAt) so the UI won't render
empty labels; update each listed key (badge__freeTrial, badge__trialEndsAt,
title__freeTrialEndsAt, title__trialSuccess, totalDueAfterTrial, startFreeTrial,
startFreeTrial__days, action__createOrganization, action__invitationAccept,
action__suggestionsAccept, subtitle, suggestionsAcceptedLabel, title,
formButtonReset, formButtonSubmit, subtitle, title, actionLink, actionText) with
appropriate Malay text or a programmatic fallback and run the linter/locale
tests to ensure no undefined values remain.
taskChooseOrganization: { | ||
signOut: { | ||
actionLink: 'வெளியேறு', | ||
actionText: '{{identifier}} ஆக உள்நுழைந்துள்ளீர்கள்', | ||
}, | ||
createOrganization: { | ||
title: 'உங்கள் கணக்கை அமைக்கவும்', | ||
subtitle: 'உங்கள் நிறுவனத்தைப் பற்றி கொஞ்சம் சொல்லுங்கள்', | ||
formButtonSubmit: 'புதிய நிறுவனத்தை உருவாக்கு', | ||
formButtonReset: 'ரத்து செய்', | ||
}, | ||
chooseOrganization: { | ||
title: 'நிறுவனத்தைத் தேர்வு செய்யவும்', | ||
subtitle: 'ஏற்கனவே உள்ள நிறுவனத்தில் சேரவும் அல்லது புதியதை உருவாக்கவும்', | ||
suggestionsAcceptedLabel: 'ஒப்புதல் நிலுவையில் உள்ளது', | ||
action__createOrganization: 'புதிய நிறுவனத்தை உருவாக்கு', | ||
action__suggestionsAccept: 'சேர கோரிக்கை', | ||
action__invitationAccept: 'சேரவும்', | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate key: taskChooseOrganization is overwritten, dropping your new translations
Second declaration (Lines 831–849) overrides the first (Lines 17–36) with undefined
values. This both breaks the locale and triggers Biome’s duplicate key rule.
Remove the duplicate at the bottom.
Apply:
- taskChooseOrganization: {
- chooseOrganization: {
- action__createOrganization: undefined,
- action__invitationAccept: undefined,
- action__suggestionsAccept: undefined,
- subtitle: undefined,
- suggestionsAcceptedLabel: undefined,
- title: undefined,
- },
- createOrganization: {
- formButtonReset: undefined,
- formButtonSubmit: undefined,
- subtitle: undefined,
- title: undefined,
- },
- signOut: {
- actionLink: undefined,
- actionText: undefined,
- },
- },
Also applies to: 831-849
🧰 Tools
🪛 Biome (2.1.2)
[error] 17-45: This property is later overwritten by an object member with the same name.
Overwritten with this property.
If an object property with the same name is defined multiple times (except when combining a getter with a setter), only the last definition makes it into the object and previous definitions are ignored.
Unsafe fix: Remove this property.
(lint/suspicious/noDuplicateObjectKeys)
🤖 Prompt for AI Agents
packages/localizations/src/ta-IN.ts lines 17-36: The file contains a duplicate
taskChooseOrganization declaration later (lines 831-849) that overwrites these
valid translations with undefined values; remove the second duplicate block
(lines 831-849) so only this correct taskChooseOrganization object remains, or
if the bottom block was intended to hold additions, merge any missing keys into
this top declaration and delete the duplicate to satisfy the duplicate-key rule.
badge__freeTrial: undefined, | ||
badge__otherImpersonatorDevice: 'மற்ற மாறுவேட சாதனம்', | ||
badge__pastDueAt: undefined, | ||
badge__pastDuePlan: undefined, | ||
badge__pastDueAt: "தாமதமான {{ date | shortDate('ta-IN') }}", | ||
badge__pastDuePlan: 'தாமதமான', | ||
badge__primary: 'முதன்மை', | ||
badge__renewsAt: undefined, | ||
badge__renewsAt: "{{ date | shortDate('ta-IN') }} புதுப்பிக்கிறது", | ||
badge__requiresAction: 'செயல் தேவை', | ||
badge__startsAt: undefined, | ||
badge__startsAt: "{{ date | shortDate('ta-IN') }} தொடங்குகிறது", | ||
badge__thisDevice: 'இந்த சாதனம்', | ||
badge__trialEndsAt: undefined, | ||
badge__unverified: 'சரிபார்க்கப்படாதது', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Fill missing translations left as undefined
Several badge and checkout keys are undefined
. Ensure there’s a fallback or add translations to avoid blank UI text.
Find them with:
Also applies to: 118-123, 166-168
🏁 Script executed:
#!/bin/bash
rg -nP ":\s*undefined\b" packages/localizations/src/ta-IN.ts
Length of output: 790
Fill missing translations left as undefined — action required
Several localization keys in packages/localizations/src/ta-IN.ts are set to undefined
and will render blank in the UI. Replace them with Tamil translations or provide an explicit fallback.
- packages/localizations/src/ta-IN.ts
- 78: badge__freeTrial: undefined
- 87: badge__trialEndsAt: undefined
- 118: title__freeTrialEndsAt: undefined
- 129: title__trialSuccess: undefined
- 130: totalDueAfterTrial: undefined
- 166: startFreeTrial: undefined
- 167: startFreeTrial__days: undefined
- 832: action__createOrganization: undefined
- 833: action__invitationAccept: undefined
- 834: action__suggestionsAccept: undefined
- 835: subtitle: undefined
- 836: suggestionsAcceptedLabel: undefined
- 837: title: undefined
- 840: formButtonReset: undefined
- 841: formButtonSubmit: undefined
- 842: subtitle: undefined
- 843: title: undefined
- 846: actionLink: undefined
- 847: actionText: undefined
Suggested fix: add the Tamil strings (or point these keys to an English fallback) and mark any untranslated items with TODO comments for translators.
🤖 Prompt for AI Agents
In packages/localizations/src/ta-IN.ts (keys at lines 78, 87, 118, 129, 130,
166–167, 832–837, 840–847 and nearby), several localization entries are set to
undefined and will render blank; replace each undefined value with an
appropriate Tamil translation or wire them to the English fallback key,
preserving any interpolation/placeholders (e.g., {{ date | shortDate('ta-IN') }}
and plural/day placeholders), and add a TODO comment for any untranslated
strings to notify translators.
taskChooseOrganization: { | ||
signOut: { | ||
actionLink: 'సైన్ అవుట్', | ||
actionText: '{{identifier}} గా సైన్ ఇన్ చేసారు', | ||
}, | ||
createOrganization: { | ||
title: 'మీ ఖాతాను సెటప్ చేయండి', | ||
subtitle: 'మీ సంస్థ గురించి కొంచెం చెప్పండి', | ||
formButtonSubmit: 'కొత్త సంస్థను సృష్టించండి', | ||
formButtonReset: 'రద్దు చేయండి', | ||
}, | ||
chooseOrganization: { | ||
title: 'సంస్థను ఎంచుకోండి', | ||
subtitle: 'ఇప్పటికే ఉన్న సంస్థలో చేరండి లేదా కొత్తదాన్ని సృష్టించండి', | ||
suggestionsAcceptedLabel: 'ఆమోదం కోసం పెండింగ్లో ఉంది', | ||
action__createOrganization: 'కొత్త సంస్థను సృష్టించండి', | ||
action__suggestionsAccept: 'చేరడానికి అభ్యర్థించండి', | ||
action__invitationAccept: 'చేరండి', | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate key: taskChooseOrganization is overwritten, dropping your new translations
The second taskChooseOrganization
block (Lines 827–845) overrides the first (Lines 17–36) with undefined
values. This introduces broken UI strings and fails linting.
Remove the later duplicate.
Apply:
- taskChooseOrganization: {
- chooseOrganization: {
- action__createOrganization: undefined,
- action__invitationAccept: undefined,
- action__suggestionsAccept: undefined,
- subtitle: undefined,
- suggestionsAcceptedLabel: undefined,
- title: undefined,
- },
- createOrganization: {
- formButtonReset: undefined,
- formButtonSubmit: undefined,
- subtitle: undefined,
- title: undefined,
- },
- signOut: {
- actionLink: undefined,
- actionText: undefined,
- },
- },
Also applies to: 827-845
🧰 Tools
🪛 Biome (2.1.2)
[error] 17-45: This property is later overwritten by an object member with the same name.
Overwritten with this property.
If an object property with the same name is defined multiple times (except when combining a getter with a setter), only the last definition makes it into the object and previous definitions are ignored.
Unsafe fix: Remove this property.
(lint/suspicious/noDuplicateObjectKeys)
🤖 Prompt for AI Agents
In packages/localizations/src/te-IN.ts around lines 17 to 36 and again at 827 to
845, there is a duplicate taskChooseOrganization key where the later block
overwrites the first with undefined/broken values; remove the later duplicate
(lines 827–845) so only the correct translations in the first block remain, and
run lint/validation to confirm no duplicate keys or undefined strings remain.
badge__activePlan: 'చురుకైన ప్లాన్', | ||
badge__canceledEndsAt: '{{date}} న రద్దు చేయబడుతుంది', | ||
badge__currentPlan: 'ప్రస్తుత ప్లాన్', | ||
badge__default: 'డిఫాల్ట్', | ||
badge__endsAt: undefined, | ||
badge__endsAt: '{{date}} న ముగుస్తుంది', | ||
badge__expired: 'గడువు ముగిసింది', | ||
badge__freeTrial: undefined, | ||
badge__otherImpersonatorDevice: 'ఇతర నకిలీ పరికరం', | ||
badge__pastDueAt: undefined, | ||
badge__pastDuePlan: undefined, | ||
badge__pastDueAt: '{{date}} నుండి గడువు దాటింది', | ||
badge__pastDuePlan: 'గడువు దాటిన ప్లాన్', | ||
badge__primary: 'ప్రాథమిక', | ||
badge__renewsAt: undefined, | ||
badge__renewsAt: '{{date}} న పునరుద్ధరించబడుతుంది', | ||
badge__requiresAction: 'చర్య అవసరం', | ||
badge__startsAt: undefined, | ||
badge__startsAt: '{{date}} న ప్రారంభమవుతుంది', | ||
badge__thisDevice: 'ఈ పరికరం', | ||
badge__trialEndsAt: undefined, | ||
badge__unverified: 'ధృవీకరించబడలేదు', | ||
badge__upcomingPlan: undefined, | ||
badge__upcomingPlan: 'రాబోయే ప్లాన్', | ||
badge__userDevice: 'వినియోగదారు పరికరం', | ||
badge__you: 'మీరు', | ||
commerce: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Populate undefined keys or ensure fallback
badge__freeTrial
, badge__trialEndsAt
, several checkout entries, and trial-related strings are undefined
. If the renderer doesn’t fall back, users will see missing labels.
Scan for undefined:
Also applies to: 114-127, 160-176
🏁 Script executed:
#!/bin/bash
rg -nP ":\s*undefined\b" packages/localizations/src/te-IN.ts
Length of output: 792
Populate missing Telugu translations in packages/localizations/src/te-IN.ts or ensure runtime fallbacks
Several localization keys are explicitly set to undefined
in packages/localizations/src/te-IN.ts — if the renderer doesn’t fallback, users will see missing labels. Please either provide Telugu strings or confirm a safe fallback.
Keys (file / line):
- packages/localizations/src/te-IN.ts
- 78: badge__freeTrial
- 87: badge__trialEndsAt
- 114: title__freeTrialEndsAt
- 125: title__trialSuccess
- 126: totalDueAfterTrial
- 162: startFreeTrial
- 163: startFreeTrial__days
- 828: action__createOrganization
- 829: action__invitationAccept
- 830: action__suggestionsAccept
- 831: subtitle
- 832: suggestionsAcceptedLabel
- 833: title
- 836: formButtonReset
- 837: formButtonSubmit
- 838: subtitle
- 839: title
- 842: actionLink
- 843: actionText
Suggested fix: replace undefined
values with proper Telugu translations or ensure the i18n layer falls back to a default locale to avoid blank UI text.
Thank you for these translations! It looks like there are some merge conflicts in the localization files. If you have a chance, could you help resolve them? Thanks again! |
Description
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change
Summary by CodeRabbit